From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Emanuele Giaquinta Newsgroups: gmane.emacs.devel Subject: Re: support for rxvt-unicode in rxvt.el Date: Sun, 25 Sep 2005 02:23:26 +0200 Message-ID: <742051605092417237bf198c1@mail.gmail.com> References: <20050921132431.GA5008@host91-100.pool871.interbusiness.it> <200509211629.j8LGTCKE019350@scanner2.ics.uci.edu> <74205160509210943718a3746@mail.gmail.com> <742051605092112545d674084@mail.gmail.com> <200509212102.j8LL2IKE011172@scanner2.ics.uci.edu> <74205160509220101adf16c@mail.gmail.com> <200509242328.j8ONSpKE027115@scanner2.ics.uci.edu> Reply-To: Emanuele Giaquinta NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1127607941 16864 80.91.229.2 (25 Sep 2005 00:25:41 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 25 Sep 2005 00:25:41 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 25 02:25:38 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EJKK8-0007rX-C0 for ged-emacs-devel@m.gmane.org; Sun, 25 Sep 2005 02:24:56 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EJKK7-0002KQ-JP for ged-emacs-devel@m.gmane.org; Sat, 24 Sep 2005 20:24:55 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EJKJb-0002GJ-Ac for emacs-devel@gnu.org; Sat, 24 Sep 2005 20:24:23 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EJKJY-0002E1-HK for emacs-devel@gnu.org; Sat, 24 Sep 2005 20:24:21 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EJKJX-0002DY-1K for emacs-devel@gnu.org; Sat, 24 Sep 2005 20:24:19 -0400 Original-Received: from [72.14.204.200] (helo=qproxy.gmail.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EJKIn-0004t0-0G for emacs-devel@gnu.org; Sat, 24 Sep 2005 20:23:33 -0400 Original-Received: by qproxy.gmail.com with SMTP id a10so332449qbd for ; Sat, 24 Sep 2005 17:23:26 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=bQrRaXGQEK0kK3Y83w93YePZPi04m7iwq9XgDO3LcpvCiDKbKcA0OWflfB5RrhQw877qKeMea0auG7u6PiRT3jw1xaFzmyLy/PV0K0WLLnypniFkzm0asTwGjsebSx6Sgcy2dSA2o2HUtIS9LL3oh5z9Am31coHeZYm8IL0d09o= Original-Received: by 10.64.204.12 with SMTP id b12mr369404qbg; Sat, 24 Sep 2005 17:23:26 -0700 (PDT) Original-Received: by 10.64.196.20 with HTTP; Sat, 24 Sep 2005 17:23:26 -0700 (PDT) Original-To: Dan Nicolaescu In-Reply-To: <200509242328.j8ONSpKE027115@scanner2.ics.uci.edu> Content-Disposition: inline X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:43205 Archived-At: On 9/25/05, Dan Nicolaescu wrote: > I got word that is OK to install your patch, so I did that. > I did not install the part that adds key bindings as it does not seem > to be needed. If the key bindings prove to be necessary we can install > them later. Very good; as Andreas pointed out, there is a redundant check on ncolors. Thanks. Index: rxvt.el =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvsroot/emacs/emacs/lisp/term/rxvt.el,v retrieving revision 1.14 diff -u -r1.14 rxvt.el --- rxvt.el 24 Sep 2005 23:20:45 -0000 1.14 +++ rxvt.el 25 Sep 2005 00:15:15 -0000 @@ -240,7 +240,7 @@ (list color color color)) (setq ncolors (1- ncolors)))) - ((and (> ncolors 0) (=3D ncolors 72)) ; rxvt-unicode + ((=3D ncolors 72) ; rxvt-unicode ;; 64 non-gray colors (let ((levels '(0 139 205 255)) (r 0) (g 0) (b 0))