unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Emanuele Giaquinta <emanuele.giaquinta@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: support for rxvt-unicode in rxvt.el
Date: Sun, 25 Sep 2005 02:23:26 +0200	[thread overview]
Message-ID: <742051605092417237bf198c1@mail.gmail.com> (raw)
In-Reply-To: <200509242328.j8ONSpKE027115@scanner2.ics.uci.edu>

On 9/25/05, Dan Nicolaescu <dann@ics.uci.edu> wrote:

> I got word that is OK to install your patch, so I did that.
> I did not install the part that adds key bindings as it does not seem
> to be needed. If the key bindings prove to be necessary we can install
> them later.

Very good; as Andreas pointed out, there is a redundant check on ncolors.
Thanks.

Index: rxvt.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/term/rxvt.el,v
retrieving revision 1.14
diff -u -r1.14 rxvt.el
--- rxvt.el     24 Sep 2005 23:20:45 -0000      1.14
+++ rxvt.el     25 Sep 2005 00:15:15 -0000
@@ -240,7 +240,7 @@
                    (list color color color))
       (setq ncolors (1- ncolors))))

-       ((and (> ncolors 0) (= ncolors 72)) ; rxvt-unicode
+       ((= ncolors 72) ; rxvt-unicode
     ;; 64 non-gray colors
     (let ((levels '(0 139 205 255))
           (r 0) (g 0) (b 0))

  reply	other threads:[~2005-09-25  0:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-21 13:24 support for rxvt-unicode in rxvt.el Emanuele Giaquinta
2005-09-21 13:52 ` Stefan Monnier
2005-09-21 14:03   ` Emanuele Giaquinta
2005-09-21 14:26 ` Dan Nicolaescu
2005-09-21 14:35   ` Emanuele Giaquinta
2005-09-21 14:50     ` Dan Nicolaescu
2005-09-21 14:58       ` Emanuele Giaquinta
2005-09-21 16:30         ` Dan Nicolaescu
2005-09-21 16:29 ` Dan Nicolaescu
2005-09-21 16:43   ` Emanuele Giaquinta
2005-09-21 17:25     ` Stefan Monnier
2005-09-21 19:54       ` Emanuele Giaquinta
2005-09-21 21:02         ` Dan Nicolaescu
2005-09-22  8:01           ` Emanuele Giaquinta
2005-09-24 23:28             ` Dan Nicolaescu
2005-09-25  0:23               ` Emanuele Giaquinta [this message]
2005-09-21 21:38         ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=742051605092417237bf198c1@mail.gmail.com \
    --to=emanuele.giaquinta@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).