unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Jim Porter <jporterbugs@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>, Tony Zorman <tonyzorman@mailbox.org>
Cc: emacs-devel@gnu.org, info@protesilaos.com
Subject: Re: Ansi-color uses the same values for fore- and background colours
Date: Wed, 9 Aug 2023 09:46:27 -0700	[thread overview]
Message-ID: <73b5085d-127d-6760-c32d-56ecd3b8a6e0@gmail.com> (raw)
In-Reply-To: <83msz0l4zb.fsf@gnu.org>

On 8/9/2023 6:28 AM, Eli Zaretskii wrote:
>> From: Tony Zorman <tonyzorman@mailbox.org>
>> Date: Wed, 09 Aug 2023 14:10:44 +0200
>>
>> by default, all of the `ansi-color-«COLOUR»' faces (defined in
>> `ansi-color.el') set the foreground and background colour to the exact
>> same value.
> 
> I believe this is intentional: that's how ANSI SGR sequences work on
> terminals, right?

Yes. Emacs *could* color the foreground and background differently, but 
I don't believe it should (users are free to customize things however 
they like, of course). Every terminal emulator I'm aware of uses the 
same palette for foreground and background colors, so I think we should 
follow suit.

Instead, the goal should be to ensure a reasonable level of contrast 
between commonly-used color pairs of different foregrounds/backgrounds. 
At minimum, SGR white or black on any of the other basic colors should 
be readable.

I don't think there's a bug here.



  parent reply	other threads:[~2023-08-09 16:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-09 12:10 Ansi-color uses the same values for fore- and background colours Tony Zorman
2023-08-09 13:28 ` Eli Zaretskii
2023-08-09 16:18   ` Tony Zorman
2023-08-09 16:31     ` Eli Zaretskii
2023-08-09 16:46   ` Jim Porter [this message]
2023-08-09 16:51 ` Jim Porter
2023-08-10  3:59   ` Tony Zorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73b5085d-127d-6760-c32d-56ecd3b8a6e0@gmail.com \
    --to=jporterbugs@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=info@protesilaos.com \
    --cc=tonyzorman@mailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).