* Re: emacs/lisp/mail rmail.el
[not found] <E1LjD5L-0002L8-TV@cvs.savannah.gnu.org>
@ 2009-03-16 17:18 ` Glenn Morris
2009-03-17 1:15 ` Richard M Stallman
0 siblings, 1 reply; 5+ messages in thread
From: Glenn Morris @ 2009-03-16 17:18 UTC (permalink / raw)
To: Richard M. Stallman; +Cc: Emacs developers
"Richard M. Stallman" wrote:
> (rmail-retry-failure): Discard rmail-ignored-headers.
This change is inconsistent with Emacs 22, and the documentation in
rmail.el and rmail.texi.
If you want this, why not just set your rmail-retry-ignored-headers
equal to rmail-ignored-headers?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: emacs/lisp/mail rmail.el
2009-03-16 17:18 ` emacs/lisp/mail rmail.el Glenn Morris
@ 2009-03-17 1:15 ` Richard M Stallman
2009-03-17 1:22 ` Glenn Morris
2009-03-19 1:29 ` recursive edit in isearch Chetan Pandya
0 siblings, 2 replies; 5+ messages in thread
From: Richard M Stallman @ 2009-03-17 1:15 UTC (permalink / raw)
To: Glenn Morris; +Cc: emacs-devel
This change is inconsistent with Emacs 22, and the documentation in
rmail.el and rmail.texi.
The problem has to be fixed. The behavior as of yesterday is so
inconvenient that I can't believe anyone wants it.
I just looked at the old Rmail code and saw this:
(rmail-clear-headers "^sender:\\|^return-path:\\|^received:")
which had got lost. Would you prefer that fix?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: emacs/lisp/mail rmail.el
2009-03-17 1:15 ` Richard M Stallman
@ 2009-03-17 1:22 ` Glenn Morris
2009-03-17 18:25 ` Richard M Stallman
2009-03-19 1:29 ` recursive edit in isearch Chetan Pandya
1 sibling, 1 reply; 5+ messages in thread
From: Glenn Morris @ 2009-03-17 1:22 UTC (permalink / raw)
To: rms; +Cc: emacs-devel
Richard M Stallman wrote:
> This change is inconsistent with Emacs 22, and the documentation in
> rmail.el and rmail.texi.
>
> The problem has to be fixed.
What problem?
> The behavior as of yesterday is so inconvenient that I can't believe
> anyone wants it.
In what way? AFAIK, nobody complained about it in Emacs 22.
If there is a problem, I think you should add elements to the default
of rmail-retry-ignored-headers (and add a :version tag), rather than
using rmail-ignored-headers for this.
> I just looked at the old Rmail code and saw this:
>
> (rmail-clear-headers "^sender:\\|^return-path:\\|^received:")
>
> which had got lost. Would you prefer that fix?
What do you mean, "had got lost"? Equivalent code is there in
rmail-retry-failure in the trunk, right where you made your change:
(rmail-delete-headers "^\\(sender\\|return-path\\|received\\):")
^ permalink raw reply [flat|nested] 5+ messages in thread
* recursive edit in isearch
2009-03-17 1:15 ` Richard M Stallman
2009-03-17 1:22 ` Glenn Morris
@ 2009-03-19 1:29 ` Chetan Pandya
1 sibling, 0 replies; 5+ messages in thread
From: Chetan Pandya @ 2009-03-19 1:29 UTC (permalink / raw)
To: emacs-devel
It looks like recursive edit in isearch mode will not save/restore. Current code will try to restore the buffer if the window buffer is different from the current buffer.
A simple change is to make sure it is so that the buffer is not restored, in case the buffer changed in the mean time.
Change
diff -u /emacs-23/lisp/isearch.el.~1.345.~ /emacs-23/lisp/isearch.el
--- /emacs-23/lisp/isearch.el.~1.345.~ Tue Feb 17 01:27:04 2009
+++ /emacs-23/lisp/isearch.el Thu Mar 19 01:24:24 2009
@@ -811,8 +811,7 @@
;; the calling function until searching is completed) by entering
;; a recursive-edit and exiting it when done isearching.
(if recursive-edit
- (let ((isearch-recursive-edit t))
- (recursive-edit)))
+ (save-excursion (set-buffer (window-buffer)) (recursive-edit)))
isearch-success)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-03-19 1:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1LjD5L-0002L8-TV@cvs.savannah.gnu.org>
2009-03-16 17:18 ` emacs/lisp/mail rmail.el Glenn Morris
2009-03-17 1:15 ` Richard M Stallman
2009-03-17 1:22 ` Glenn Morris
2009-03-17 18:25 ` Richard M Stallman
2009-03-19 1:29 ` recursive edit in isearch Chetan Pandya
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).