From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: Merging scratch/substitute-command-keys to master Date: Sat, 17 Oct 2020 10:22:52 -0700 (PDT) Message-ID: <72f3d9b9-fa2a-4116-a817-6dcb7f74e97b@default> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31808"; mail-complaints-to="usenet@ciao.gmane.io" To: Stefan Kangas , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 17 19:23:34 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kTpvZ-00087X-L1 for ged-emacs-devel@m.gmane-mx.org; Sat, 17 Oct 2020 19:23:33 +0200 Original-Received: from localhost ([::1]:49544 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kTpvY-000259-LC for ged-emacs-devel@m.gmane-mx.org; Sat, 17 Oct 2020 13:23:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36436) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kTpv3-0001fp-BX for emacs-devel@gnu.org; Sat, 17 Oct 2020 13:23:01 -0400 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:43268) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kTpv1-0008UL-8Z for emacs-devel@gnu.org; Sat, 17 Oct 2020 13:23:00 -0400 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09HHIm3P190905; Sat, 17 Oct 2020 17:22:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=c9sYMSDD7oNwHnfgjqYT4pFCfiePhRpcY8+Mr/E3sD8=; b=RFAz/kjUZT5DVDI8BROz3nziIxbpuCNPeJmXHJk+uz1ljvgL7R33F+ttvPjvpz5tEpvS S1N8Jh4RYoX4axqXKlJQCrEBjB0s3B4P8QYsv0zi9Af4lCCbN2Ij+GTkUyXv/zjyOLvk 7oJye1l9gWYD6ICyajjShX2ynqIQsGK+y9hkXIK/HkYJCYnybnNgZZAxGkPIbhMsRNBA hIxRfkM9+LlqxXQi04MtCH3ykfjXk2eqOoCm4xCUO/LE7sPLy6kQavTp4KamlYPpgXlx MfZAMa8sPkpwzK4ZmCZLIf/8c8LIOEdGbB/7gdisHFocxwYUnI7FZV2vSgMtEvaFyHCZ HQ== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 347rjkh36y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 17 Oct 2020 17:22:57 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09HHKjch049383; Sat, 17 Oct 2020 17:22:56 GMT Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 347nqs2et0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 17 Oct 2020 17:22:56 +0000 Original-Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 09HHMrsJ032293; Sat, 17 Oct 2020 17:22:53 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5056.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9777 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 adultscore=0 phishscore=0 malwarescore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010170122 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9777 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=999 bulkscore=0 spamscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 clxscore=1015 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010170122 Received-SPF: pass client-ip=141.146.126.78; envelope-from=drew.adams@oracle.com; helo=aserp2120.oracle.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/17 13:11:31 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:257955 Archived-At: > I've been working on translating `substitute-command-keys' from C to > Lisp, and I think it's getting ready to merge to master. =20 Sounds good. Thanks for working on this. I hope you'll consider adding help buttons for key descriptions, as is done in my function `help-substitute-command-keys' (in `help-fns+.el), which I think you've seen. Doc: (help-substitute-command-keys STRING &optional ADD-HELP-BUTTONS) Same as `substitute-command-keys', but optionally adds buttons for help. Non-nil optional arg ADD-HELP-BUTTONS does that, adding buttons to key descriptions, which link to the key's command help.