From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.devel Subject: Re: master 95b1eacd47: Fix handling of UNCs in 'parse-colon-path Date: Wed, 24 Aug 2022 18:03:35 -0400 Message-ID: <72e69a8e-13ba-f36f-d6bd-c4ed4bb0e53e@cornell.edu> References: <166135805961.19216.9573795919733967151@vcs2.savannah.gnu.org> <20220824162100.7A8DFC0088A@vcs2.savannah.gnu.org> <1a7d3a5b-6022-906f-8bc3-9280ff1ad4c2@cornell.edu> <83v8qh4gw2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1766"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 25 00:04:42 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQyUM-0000GA-3q for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Aug 2022 00:04:42 +0200 Original-Received: from localhost ([::1]:35496 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQyUK-0004Xp-P8 for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Aug 2022 18:04:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51690) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQyTP-0003rO-IV for emacs-devel@gnu.org; Wed, 24 Aug 2022 18:03:43 -0400 Original-Received: from mail-dm6nam12on2114.outbound.protection.outlook.com ([40.107.243.114]:2304 helo=NAM12-DM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQyTN-0004Y2-BX; Wed, 24 Aug 2022 18:03:42 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C/fc84oL+iQbzb04+u3C2uqRWHs0UbUnoUI0i6i1KdPLdXsXKlo8dE8TwOa7C8n35O6UvJv/bVRoVtDBUipi8rcm/VdhiyVI6Ur48ndQvtBEUgSZDrS2ZywqLSdLgw8DftHbLPtG9I+IYqeZt2luxhR7I1SFBbSSuwJ3GqggoE7fc8X3KZb1iVJoRfjz+/4fw+ql7zu0DSlF706OxmF+3iNq126vB0I3SLRq1nw/UE2YZ/nLy2cORzxbhehXir5BRMq2/CoZkcsZuC5Jaz/IfhAeHKWNeE7E9Vr2HbN5VMczzLKcD94Y4y+ZCTDnnIPtUydoH19WAYfRS80ipRi2uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1ozUF9DF0vQxRDEw5De0mrlNrHNgMQLAhvy/z13GMNY=; b=Ce5PtSAQLg+UEtuzFVrRtIYGmkWvcFGLQ6dLhhrezKicderOTUcF/Xa21P4xydBcrJEKmdrGGzNwROJYVHBBvFhULv2LIzXodWeXzJdJpOtL8hmoPun1JeuWkvvIYk/YwWPHCL4V6Dy5QfSqCZZZ51hPNGh39vzkJRkFs8gYEKALUPn6PJhU1Rcd7gNg769KBz4oZWcZpshS8vN7msnbLOob+d4dEUCaXaN2nfKV18Ic/gjf0gaP5qjKjQ5PJ64z68w4btfSvbBxS4jOCnAGOyTZZlR6kNKe8Nvc1JcdxeO86M9O6sOoKQFtWfFfr+JhttrjfagaagvLiBKwT9BKPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cornell.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1ozUF9DF0vQxRDEw5De0mrlNrHNgMQLAhvy/z13GMNY=; b=WkYPE1SDJNL50EUZRqXoHWwUisajMlOJmerRJnl8OIPqjI5LI8yqumTerKbbx0zFrzawX1cbsoYN4Cc08PfE+HLvZ4XUCabfx09QTalswy1k/rl1NelnMTO877eotmieHohvqDXwo/v+E05VfYs9QwE8+B4tMcMC1P5p+VFV4mU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cornell.edu; Original-Received: from BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) by MW4PR04MB7393.namprd04.prod.outlook.com (2603:10b6:303:7b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Wed, 24 Aug 2022 22:03:37 +0000 Original-Received: from BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::4417:167:d80b:6dcd]) by BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::4417:167:d80b:6dcd%5]) with mapi id 15.20.5546.022; Wed, 24 Aug 2022 22:03:37 +0000 Content-Language: en-US In-Reply-To: <83v8qh4gw2.fsf@gnu.org> X-ClientProxiedBy: BLAPR03CA0063.namprd03.prod.outlook.com (2603:10b6:208:329::8) To BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f06c9ed9-a447-4944-52e2-08da861c7eba X-MS-TrafficTypeDiagnostic: MW4PR04MB7393:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: akzEcpD+IX3cLY0BTyT9HeikyBCXFN/Mu/KNhfxq0LJrB/wJ1reDecZfewGWp1bnt8aCWWE8myxGpoq9gNRkRF66e7qV/Cz63YKgE4dJctQVV4dFrDb7w1ro2G61hLmpo3MQQf1NEglrk/u0k6lqB99XYFJQpcIkRJEtMwGSrgBctc80bVGHJXNbpEYKXKykOgs1R1Ez7X/qWzyamMY+YVghgaFegbKvvQV0K77T960zpYdOmHJxUz54DXiM3O/FtY9iuH2sxOZ5liS4hQtOrEJkiC4fU8G8lyTIJX6Lpxuz/lduCSmqtoP/rXocahHX2gYapr8quDBFbky3IXLGpGKgWnRTw2fTPKmjQ87GJ9PJHxgTqSEqb5uqQvO7gwJoYb3UUBjrI2l/t+GpI+JFKeC6vOdGZk278pfGUkFWCXrRo+mxmcTzqqlWLVkrBUXgZ73x+3PL4NW8a55JSaA8ofqRHxZAIs4SzEW2cLr+nyclQZEQT4W0bW1rLJe8cZUILPVuYqT8u3Hs9cQw77BLYQzCpoDyvi6VK/jyhoA+bUB38oqHFTgJB6+UBUV29rkiLFAWx/ttjZsBXAtQ64I2AYhte9nKfr9ayI0djZacGfC3xXh22pET/8e6Hf7Jm/un0b9Jit/pIE0Cbdqb3f67qQoAMm9InoZtp0SaT2u4yl7TBX1wup7wyusY6Ms6dRYjzi+TSnp/ymHJD6oB5Sb3zk2eN7sKJ0gXVJuvXHlOb13fOgGwVBphXWyDd3M0e SVkzIvtlc9tIrUtV15Jm3nbhl72peev7XJY31TXqftWg/E= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN7PR04MB4388.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(376002)(136003)(346002)(39860400002)(396003)(53546011)(6512007)(6506007)(31696002)(6916009)(86362001)(41300700001)(478600001)(6486002)(83380400001)(38100700002)(75432002)(41320700001)(2906002)(450100002)(186003)(2616005)(66476007)(31686004)(8936002)(66556008)(4326008)(5660300002)(66946007)(8676002)(316002)(786003)(36756003)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WmNDd1RqcjdkcjhwWlg0cFFRQzFCQ3QvT1hEOUhscXYyZjJHVEh2eHk3V0FH?= =?utf-8?B?emljM1FLSzZBUENCSDlickNoQVZDMmZKMGxabVFkWDg4bWIyOTJWY2U0Qiti?= =?utf-8?B?Q2lrak1nR0QyUHJ1dUJTbGphUjBLQ3FWTkJES3A5ckw3aXlaN2oveWJCcGhz?= =?utf-8?B?dFNrRXQ4eUVvOGZWRWlob1dUQVZ3YWxyZWdjbWpOVHpIcS9FdmdwaDNrTWY2?= =?utf-8?B?MW04WjRlVXFaTFZyUUlCd1BvT1pyaHFhekQzM25nWlptYmNvYkJtajNCYTV6?= =?utf-8?B?NmdaTHE5TThyL0RUV1FOMXg1N1R1OUM1d1E2RHJRWFJnck5hU2ZidHdPMnVy?= =?utf-8?B?ek9weVZTckpZbGlIOGVmaXpaZURPZFpOdk55WHhaQ25NQldWQXlUN2NWd2d4?= =?utf-8?B?NXZPcXNOS1hzK0JLYnkwRHlQK24yakoxOTNBOEgzdW1qVkR0T0xuNXVNdTRB?= =?utf-8?B?dUVONmk5d3NqeWZiR2ZORGE0N2ZOdzMvc1NLdy95VFZhbmVHdVlRTEQ4bldm?= =?utf-8?B?STZ4VjdCWURjazF0UUszWGpjTWN5NlJNbU41N3dXbzlMOU1obEtJeDhaVEZC?= =?utf-8?B?eFRpb0pxSzY1b1NFeDhGNVJKSHgrMEhQS2swU3d2c0J2VUpvZkpWbC9nT3ht?= =?utf-8?B?RTVnTFlNMkxLSWhaMG9WWUprYWpKa1owMmFMT1 X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: f06c9ed9-a447-4944-52e2-08da861c7eba X-MS-Exchange-CrossTenant-AuthSource: BN7PR04MB4388.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2022 22:03:37.1880 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dUNCDTY+IKNjKQLmOBlKJBAfB/uJ/mmAo+pniuR6oNNo+mpwu/R39khNf1JDxKcqkEO9L13DyHDS6jNyh/zhIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR04MB7393 Received-SPF: pass client-ip=40.107.243.114; envelope-from=kbrown@cornell.edu; helo=NAM12-DM6-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294050 Archived-At: On 8/24/2022 2:48 PM, Eli Zaretskii wrote: >> Date: Wed, 24 Aug 2022 14:34:02 -0400 >> From: Ken Brown >> >> On 8/24/2022 12:20 PM, Eli Zaretskii wrote: >>> branch: master >>> commit 95b1eacd4750da7329380aabcb383a8f9d96a59b >>> Author: Eli Zaretskii >>> Commit: Eli Zaretskii >>> >>> Fix handling of UNCs in 'parse-colon-path >>> >>> * lisp/files.el (parse-colon-path): Don't remove the second >>> leading slash on systems that support UNCs. (Bug#57353) >>> >>> * test/lisp/files-tests.el (files-tests-bug-21454): Update >>> expected results. >>> (files-colon-path): Add a new test pattern. >> >> After this commit I'm getting the following test failure on Cygwin. I don't >> have time to look into it now, but I can do so in a few days if the fix isn't >> obvious. > > Ugh, it means the test data needs to be split three-way: one for > MS-Windows/MS-DOS, another for Cygwin, and one more for the rest. > Because Cygwin is like Posix systems, but it does want to support > UNCs. It's not just the test data that's wrong on Cygwin, but parse-colon-path is wrong: It always collapses multiple leading slashes to two. Posix says that multiple leading slashes are equivalent to one slash *except* in the case of exactly two leading slashes. In that case, the interpretation is implementation-dependent. Cygwin follows Posix and chooses to interpret precisely two leading slashes as referring to a UNC path. In particular, 3 or more slashes should be collapsed to 1 slash, as on other Posix systems, while exactly 2 leading slashes should be left alone. Ken