From: Alexander Adolf <alexander.adolf@condition-alpha.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Thoughts on Refactoring In-Buffer Completion In message.el
Date: Fri, 22 Jul 2022 15:58:13 +0200 [thread overview]
Message-ID: <72cd181d4397e8f1367a60b257320692@condition-alpha.com> (raw)
In-Reply-To: <e20052b75483d236e468b183719faa95@condition-alpha.com>
It's too hot to think today. I deserve to correct myself in two points.
Alexander Adolf <alexander.adolf@condition-alpha.com> writes:
> [...] I.e. there would not be any "degradation" in terms of
> end-user functionality (same set of completion candidates as before),
> and additional sources like e.g. LDAP, and macOS Contacts would become
> available "for free" by calling eudc-query-with-words with its new
> TRY-ALL-SERVERS parameter set to t.
Nope.
Instead of eudc-query-with-words, the call would go to
eudc-capf-message-expand-name from eudc-capf.el, of course. I'd add two
new, optional parameters BEG and END to eudc-capf-message-expand-name,
so the prefix bounds can be passed down from message.el.
> It would seem that quite a couple of lines of code could be "commented
> out" of message.el under `(if (<= emacs-major-version 29) ...)` as a
> result of such a change.
> [...]
That doesn't seem quite right either.
Unless we're trying to plug a new message.el into an old set of lisp,
the code can simply be removed from message.el.
Hope that clarifies,
--alexander
next prev parent reply other threads:[~2022-07-22 13:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 15:26 Thoughts on Refactoring In-Buffer Completion In message.el Alexander Adolf
2022-06-25 4:35 ` Thomas Fitzsimmons
2022-06-27 15:48 ` Alexander Adolf
2022-06-25 8:22 ` Stefan Monnier
2022-06-27 16:37 ` Alexander Adolf
2022-06-28 15:49 ` Stefan Monnier
2022-07-19 21:41 ` Alexander Adolf
2022-07-19 22:13 ` Stefan Monnier
2022-07-20 20:59 ` Alexander Adolf
2022-07-20 23:59 ` Stefan Monnier
2022-07-22 13:20 ` Alexander Adolf
2022-07-22 13:58 ` Alexander Adolf [this message]
2022-07-27 21:16 ` Alexander Adolf
2022-08-17 2:45 ` Stefan Monnier
-- strict thread matches above, loose matches on Subject: below --
2022-08-13 13:11 Alexander Adolf
2022-08-17 1:54 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72cd181d4397e8f1367a60b257320692@condition-alpha.com \
--to=alexander.adolf@condition-alpha.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).