From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: Suggesting that feature/tree-sitter be merged (was Re: Tree-sitter and major mode inheritance) Date: Fri, 18 Nov 2022 14:58:17 -0800 Message-ID: <72C5E060-76D5-45C7-80E8-C794468DAAB8@gmail.com> References: <0249C656-21C8-49F2-B979-A1894BF80637@gmail.com> <874juvhoyi.fsf@posteo.net> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8521"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= , emacs-devel , Theodor Thornhill , Eli Zaretskii , jostein@kjonigsen.net To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 18 23:59:17 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owAKL-0001sq-3w for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Nov 2022 23:59:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owAJV-0005zH-Jb; Fri, 18 Nov 2022 17:58:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owAJT-0005yu-AG for emacs-devel@gnu.org; Fri, 18 Nov 2022 17:58:23 -0500 Original-Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1owAJR-0007Y3-FS; Fri, 18 Nov 2022 17:58:22 -0500 Original-Received: by mail-pf1-x429.google.com with SMTP id y203so6227429pfb.4; Fri, 18 Nov 2022 14:58:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=S3yHWcjFsBRBYI92yyxYSOtmuyU1yeZhYtOx6CyI67s=; b=Xi9ARz5+VN12Dj6pENqmsLV+5Db1LvjnK6hUsrATEEoVqVYGNKtJQerz/bOvunigyX FklRoblIl3I+plm7MFkcASy5nQEaNTd/Hx7GjNP7uPTB5KV30ZofYX8wz/n97LLKGFuB UBmWQF1+bXCHN7SqR4uPStcwWO57aXoQLRiBrKgbgKqa8WZTpN5wcms4sTFhDx0YwXPu h9KTPzpPItN1YW5l8TqNUaQz7is1rTU4k2FE5axHa/Dtm4/3Aim5utg+XeQ1GqXIoxCC EK1EbCM9K7BZB6t1SkgcApHHFyD45NFhfBD1G5wQ3V+zDj2h4UhczQtzDwLvkgFpcAPs 63aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S3yHWcjFsBRBYI92yyxYSOtmuyU1yeZhYtOx6CyI67s=; b=EbqQBsq4+35oFXKkrcMVvdxMvHV448h0p9lPJoYQZ0Q6LrcTHMKJVBAPinXTVRa8b4 tZmCe87FhGG9En2lcq35zfub9VK6ojyWMn3zJ6kzH1bZ2GhF7ahaPaoPYlN4PQF5vPU7 HAAOGc0qh4i3XfAp+XzMayYsMNa5MHNhUJwUok06Rg9Xw51X6OtYxe3SYfvOIxvqlrVT T+iX3UHyA5DEU7l63f/hcYAhl8gOpglNrz53m0CMTCtsrsZJmbDdUXp0loAfp+R9TZpM SlqOVTIXtfnwLK/ibl6+IGwYM1ffk58qcvd/3P0ZlvDaJmwdckrJMo6tgKKDOFiUMRJZ L/Zw== X-Gm-Message-State: ANoB5pnEzOh1tlixxMZu5GoiiiTFsphXAsUmuZGdKRyBRAc+c/3d4jvr qqAOMm5BqQuRoVUd/qPN9fbwUWSyQgZyuQ== X-Google-Smtp-Source: AA0mqf75KftQhz5J6L9lDaB2NFWB4rahqxjRwX52InEc97HKH18G+ijFao4m0El9MomCsERqbBcNQw== X-Received: by 2002:a65:49cb:0:b0:477:27f7:794a with SMTP id t11-20020a6549cb000000b0047727f7794amr5648115pgs.58.1668812299407; Fri, 18 Nov 2022 14:58:19 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id u71-20020a62794a000000b00562019b961asm3694572pfc.188.2022.11.18.14.58.18 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Nov 2022 14:58:19 -0800 (PST) In-Reply-To: <874juvhoyi.fsf@posteo.net> X-Mailer: Apple Mail (2.3696.120.41.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::429; envelope-from=casouri@gmail.com; helo=mail-pf1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300127 Archived-At: > On Nov 18, 2022, at 2:34 PM, Philip Kaludercic = wrote: >=20 > Jostein Kj=C3=B8nigsen writes: >=20 >> Instead of waiting for "every" major-mode to be re-implemented into a >> tree-sitter derivative in the feature/tree-sitter branch before we >> merge... How about we just accept the current "core" tree-sitter >> implementation as good enough, and consider merging that to git = master >> as is. >=20 > I think this sounds like a good idea -- as someone who has mostly just > been following the discussions. The core bindings and major modes = that > are based on these are separate issues, with a clear dependency linked > them. >=20 > As an aside: This might also be a good opportunity to clean up some of > the current major mode implementations and make them more consistent. > The issue with custom options to enable tree-sitter for every major = mode > has revealed an inherent duplication of features. There are other > inconsistencies, especially regarding bindings for equivalent = operations > (e.g. in interpreted language with a repl, how to load function into = the > current session: Lisp, Prolog, Python all differ in minor details). I=E2=80=99ve though of this too, other things are indent level, and = documentation. I wrote ghelp[1] to get a uniform interface for getting = documentation in different major modes (because I don=E2=80=99t have the = heart to understand and modify help.el). A builtin, unified = documentation system would be nice, like eldoc. But eldoc is for = at-point short and quick signature/doc more than for full-fledged = documentation like help.el. > I can imagine a more specialised `define-generic-mode' could be of use > here, along with more "abstract" major modes for various types of > programming languages (using `prog-mode' as a base to add > `compiled-prog-mode' that has generic commands for building program, > `interpreted-prog-mode' that has generic commands for REPL > communication, ...), where the tree-sitter configuration would be one = of > the attributes these modes would specify. Sounds nice. Though what do you mean by =E2=80=9Cone of the = attributes=E2=80=9D? >> How about it? Are there any good arguments for NOT merging >> feature/tree-sitter at this point? :) >=20 > The current branch has major modes, should these be deleted before > merging? I think they can stay, we=E2=80=99ll work on them and improve them = before branch is cut. Yuan=