From: Kai Ma <justksqsf@gmail.com>
To: emacs-devel@gnu.org
Subject: Text shadows
Date: Sun, 12 Mar 2023 12:06:28 +0800 [thread overview]
Message-ID: <72650A07-DEC8-4E08-A524-5C7AF804F3CB@gmail.com> (raw)
Hi emacs
Recently, I implemented the “text shadows” feature for Cairo-powered windowing systems, including X11 and Wayland. See [1] if you wonder what that looks like.
This feature adds a new face attribute :shadow, and accepts values like:
- FLOAT how much blurring?
- (FLOAT . COLOR) additionally, specifies a color for the shadow
- (FLOAT COLOR OFFSET) additionally, specifies an offset (x . y)
This was first implemented for the NS port three years ago (also by me), and seems to have sparked some interest and was discussed on emacs-devel [2]. (I didn’t follow the discussion on emacs-devel back then.)
I’m writing to ask if the community is interested in accepting this feature into mainline Emacs? If so, I will improve things and make a formal patch.
Also, I’d like some feedback on the design and the implementation [3]. The Gaussian blurring function used GCC vector extensions. Is this allowed in the Emacs code?
There is also a known issue regarding text extents (?), and I’d like to know what is the correct path forward:
1. The shadows sometimes should be drawn outside the glyph extents, but they aren’t drawn.
2. Previously drawn shadows are not cleared, and they even accumulate. This can be observed with blink-cursor-mode enabled.
Any input would be greatly appreciated!
[1] https://github.com/ksqsf/emacsmoe/pull/1#issuecomment-1465072298
[2] https://lists.gnu.org/archive/html/emacs-devel/2020-05/msg02921.html
[3] https://github.com/ksqsf/emacsmoe/pull/1/files
— Kai
next reply other threads:[~2023-03-12 4:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-12 4:06 Kai Ma [this message]
2023-03-12 4:18 ` Text shadows Kai Ma
2023-03-12 7:12 ` Eli Zaretskii
2023-03-12 8:24 ` Kai Ma
2023-03-12 8:46 ` Po Lu
2023-03-12 9:23 ` Kai Ma
2023-03-12 10:33 ` Po Lu
2023-03-12 9:14 ` Eli Zaretskii
2023-03-12 9:55 ` Kai Ma
2023-03-12 11:33 ` Eli Zaretskii
2023-03-12 11:49 ` Kai Ma
2023-03-12 12:36 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72650A07-DEC8-4E08-A524-5C7AF804F3CB@gmail.com \
--to=justksqsf@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).