From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: master c69858b3f0: ; * lisp/treesit.el (treesit-ready-p): Guard against empty buffers. Date: Tue, 22 Nov 2022 18:18:43 -0800 Message-ID: <7230A71A-F300-4645-AE57-A1EF60EA5FF8@gmail.com> References: <166916717199.12853.3816069320355351676@vcs2.savannah.gnu.org> <20221123013252.46814C004B6@vcs2.savannah.gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21152"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel , Eli Zaretskii To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 23 03:19:19 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxfM7-0005KF-IV for ged-emacs-devel@m.gmane-mx.org; Wed, 23 Nov 2022 03:19:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxfLi-0006M6-IJ; Tue, 22 Nov 2022 21:18:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxfLd-0006Le-6x for emacs-devel@gnu.org; Tue, 22 Nov 2022 21:18:49 -0500 Original-Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxfLb-0001Bo-DB; Tue, 22 Nov 2022 21:18:48 -0500 Original-Received: by mail-pl1-x634.google.com with SMTP id j12so15391239plj.5; Tue, 22 Nov 2022 18:18:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=my+oc2w1JLuN4iyhnOML0NvQVmUvsGlto4Q2JVBklKU=; b=OAXICdvPNIBmOWMcSvc8iWcZjVvUsBFNk015fWYnVTH9YcqpC4aMv/aGYM+WFfWYCb toVeeDChIa22Yt0bblMBWVopSX0Mn0aSq3mG3FdAgq658fSw4UeguJX7NRTbT3QjVlcr gcrHHbSaM86+yVdmhoYNVQD9XTjBLl3brkFWbV/3fI2U4F3ZVmtFQwNbor3CgFoblBMu Vpx0dGaxzd4/sureJaYpwAihwYuULBDHgPjaJpXU5GEtIgZTyZNjrMd1Z+2fH6H4IOxA N/z9vFtSexmnoAkBg+JOdpPQZGMaOv2maDTYhsWQHg8VvT9AsC54CkQPdjfWvXB9jbVm YZvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=my+oc2w1JLuN4iyhnOML0NvQVmUvsGlto4Q2JVBklKU=; b=p1pRjgq4xoW26Ne+qg3ak/FZfXbFTZgV9xZvhjPFy2XEx63HdidMcdb1nhZxYp1NF7 WL9jelxRpVbfawHz0Bt14N/D35DF0Xs7iNXvmukTZeYBoPVMJzsUd6nsDeXRRxsy8UIR Xaf6m8azZOu7Sx4ZfQfzQ9+2qQ4HYVbvRGZjttM7CiUXg6S9swQCMblFP7E38fGUvzg1 YyayBjxhj5xAUyiRh8EDeyex/91+UXLgbJkhNasfp5VQ8j6xDUADHxE71IkwhiXZK0CB 8JbRZVnBoX1xntAZ04tjJU6b+r0pxRONHRjwGIISY+fiahRegoc4kNA7r4GcilqOIyK5 u6+Q== X-Gm-Message-State: ANoB5pksl4H9U6qCWsuoOoUMahyvm+6NJIOE6Wrst8j6tsdP/kPK66Vg 86A/kKFwvMCnH6E4oObaKPVH91sYhFGO3g== X-Google-Smtp-Source: AA0mqf6db325E7TX9nb4fVRXRnCy/zkOKqVFtmhtjdGkn0YKuTjo65SWKzj2ty/fR2L7hIkCJ6quUw== X-Received: by 2002:a17:903:300c:b0:188:f663:e2e7 with SMTP id o12-20020a170903300c00b00188f663e2e7mr10241183pla.121.1669169925433; Tue, 22 Nov 2022 18:18:45 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id a26-20020aa78e9a000000b0056bbd286cf4sm11262451pfr.167.2022.11.22.18.18.44 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Nov 2022 18:18:44 -0800 (PST) In-Reply-To: X-Mailer: Apple Mail (2.3696.120.41.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::634; envelope-from=casouri@gmail.com; helo=mail-pl1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300373 Archived-At: > On Nov 22, 2022, at 5:51 PM, Stefan Monnier = wrote: >=20 >> - (when (> (position-bytes (1- (point-max))) = treesit-max-buffer-size) >> + (when (> (position-bytes (max (point-min) (1- (point-max)))) >> + treesit-max-buffer-size) >=20 > I'd expect `treesit-max-buffer-size` to be compared to `buffer-size` > rather than to buffer positions. > Is it really that important to count bytes rather than characters? I=E2=80=99m not sure, I=E2=80=99ll leave Eli to explain his intention = :-) Yuan=