From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: "Eli Zaretskii" <eliz@elta.co.il>
Newsgroups: gmane.emacs.devel
Subject: Re: emacs -q -nw --color=never
Date: Wed, 24 Sep 2003 20:35:52 +0200
Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org
Message-ID: <7137-Wed24Sep2003203552+0300-eliz@elta.co.il>
References: <200309211848.h8LImLn02488@raven.dms.auburn.edu>	<E1A1Md4-0003GU-Bd@fencepost.gnu.org>
	<2914-Mon22Sep2003184812+0300-eliz@elta.co.il>
	<E1A292u-0004V3-FS@fencepost.gnu.org>
Reply-To: Eli Zaretskii <eliz@elta.co.il>
NNTP-Posting-Host: deer.gmane.org
X-Trace: sea.gmane.org 1064426087 29289 80.91.224.253 (24 Sep 2003 17:54:47 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Wed, 24 Sep 2003 17:54:47 +0000 (UTC)
Cc: teirllm@dms.auburn.edu, emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Wed Sep 24 19:54:45 2003
Return-path: <emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org>
Original-Received: from quimby.gnus.org ([80.91.224.244])
	by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 1A2Dqf-0003Wz-00
	for <emacs-devel@deer.gmane.org>; Wed, 24 Sep 2003 19:54:45 +0200
Original-Received: from monty-python.gnu.org ([199.232.76.173])
	by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian))
	id 1A2DxT-0005dJ-00
	for <emacs-devel@quimby.gnus.org>; Wed, 24 Sep 2003 20:01:48 +0200
Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.22)
	id 1A2DpZ-0004cZ-KE
	for emacs-devel@quimby.gnus.org; Wed, 24 Sep 2003 13:53:37 -0400
Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.22)
	id 1A2Dnt-0004Ay-T5
	for emacs-devel@gnu.org; Wed, 24 Sep 2003 13:51:53 -0400
Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.22)
	id 1A2Dnq-00049b-OQ
	for emacs-devel@gnu.org; Wed, 24 Sep 2003 13:51:51 -0400
Original-Received: from [192.114.186.18] (helo=bilbo.inter.net.il)
	by monty-python.gnu.org with esmtp (Exim 4.22)
	id 1A2Dnq-00048A-2U; Wed, 24 Sep 2003 13:51:50 -0400
Original-Received: from zaretski (pns03-208-8.inter.net.il [80.230.208.8])
	by bilbo.inter.net.il (Mirapoint Messaging Server MOS 3.3.7-GR)
	with ESMTP id BMW63552; Wed, 24 Sep 2003 20:38:30 +0300 (IDT)
Original-To: rms@gnu.org
X-Mailer: emacs 21.3.50 (via feedmail 8 I) and Blat ver 1.8.9
In-reply-to: <E1A292u-0004V3-FS@fencepost.gnu.org> (message from Richard
	Stallman on Wed, 24 Sep 2003 08:47:04 -0400)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.2
Precedence: list
List-Id: Emacs development discussions.  <emacs-devel.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org
Xref: main.gmane.org gmane.emacs.devel:16607
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:16607

> From: Richard Stallman <rms@gnu.org>
> Date: Wed, 24 Sep 2003 08:47:04 -0400
> 
> I see you made some changes that would fix this bug, but there
> are other bugs too.
> 
> What do you think of this version?

AFAICS, the only real change is this fragment that is absent in the
current codebase:

>   /* Canonicalize negative numbers to -1.  */
>   if (mode < 0)
>     mode = -1;

I don't really object, but what problem would that solve?  The value
of `mode' is not supposed to be negative unless it's -1.

Did I miss any other changes in the version you suggested?