From: Glenn Morris <rgm@gnu.org>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: emacs-devel@gnu.org
Subject: Re: trunk r113641: * test/automated/file-notify-tests.el (file-notify--test-remote-enabled):
Date: Fri, 02 Aug 2013 03:12:13 -0400 [thread overview]
Message-ID: <6zy58ktvle.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <87bo5g1tdg.fsf@gmx.de> (Michael Albinus's message of "Fri, 02 Aug 2013 08:47:39 +0200")
Michael Albinus wrote:
> I fear this is not sufficient. This patch handles only file
> notifications which are implemented via tramp-sh.el.
>
> Yesterday, I have committed a patch which adds
> `tramp-gvfs-handle-file-notify-add-watch' (using gvfs-monitor-file to
> poll for changes on GVFS mounted directories).
>
> Maybe we rethink to introduce `file-notify-supported-p' and its
> handlers?
You'd know better than me, I was just tying to get rid of the
(ert-test-failed
(file-notify-error "No file notification program found on /ssh:localhost:"))
from eg
http://hydra.nixos.org/build/5635144/log/raw
It succeeds in that regard.
Does it matter outside of automated testing if one gets an error?
> PS: Don't worry when I do not react next days. Tomorrow I'll start a
> bike tour, and unfortunately my companions insist on the basic rule "no
> electronic devices on board".
Good for them! :)
next prev parent reply other threads:[~2013-08-02 7:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1V521H-0006zR-8a@vcs.savannah.gnu.org>
2013-08-02 6:47 ` trunk r113641: * test/automated/file-notify-tests.el (file-notify--test-remote-enabled): Michael Albinus
2013-08-02 7:12 ` Glenn Morris [this message]
2013-08-02 7:28 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6zy58ktvle.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).