From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel Subject: Re: MPS: dangling markers Date: Wed, 03 Jul 2024 18:46:31 +0000 Message-ID: <6r7qNfDbwPzVsGeV6BB2z9gd_MVhUNLrf7m1eBXvyxTr7VDb6VnyD422kOfqblwlnDLSeaIAQExSREX2ZnoQDPsOqFGX1XqdcHXTpIHIhEs=@protonmail.com> References: <87v81u85hv.fsf@localhost> <1osQTI7Swoo72EJbCzzi4zqVXuC5hSlYEXwLtnal8_pyYL7oRCNSJg20XgBRjffZ344Wj7lwFDc9JSMsQ-3su6uXQ8hYSfYleRn-4GRrykI=@protonmail.com> <868qyldjqi.fsf@gnu.org> <_nyaStUr9UjwGJZ-bqaGNyxgCMuh-bglMdWw2rpGNja9pdNct6lfF2QXthIQFfjn2-n-T3R4WCuHMLdmIuoRzzAfuHrw0Q1rq3V-5oFLzDE=@protonmail.com> <8634osdohs.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39507"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, yantar92@posteo.net, monnier@iro.umontreal.ca, emacs-devel@gnu.org, eller.helmut@gmail.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jul 03 21:21:09 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sP5XR-0009zB-99 for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Jul 2024 21:21:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sP5Wm-0007jE-UT; Wed, 03 Jul 2024 15:20:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sP508-0008As-PQ for emacs-devel@gnu.org; Wed, 03 Jul 2024 14:46:45 -0400 Original-Received: from mail-4316.protonmail.ch ([185.70.43.16]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sP505-00061n-Qt; Wed, 03 Jul 2024 14:46:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1720032396; x=1720291596; bh=nQxBACILjuhsHLbemEaP9nOlDh7N+gY/jeoDlA7JYFM=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=CiLb6PGU+gS3AcsaLCSuKKMhRR0lFVY82aGZ7rzASbI6fgkSjOb031sxwdwVTAI7e xzlLo6nu4dkydfaB9SS+iEVRqKWVZ7rVELRwC8rXwI0IvaZSnatz4r0AeUyRhtmag0 227IswtNJsN760FfnWpZ4pYdlEBN2KNp2kEnW0tbxH+ZYjsErdgeex7UWHTUNYLD3w Lv/DVsWauTvvLTvQY50UXIeQ7GqWMm6xaX4zAf8CvOwj63ViqnuaBU8+8HSL5yJlvF DI2KTbieTVOwYeRivo4naE+Hb+wBtkvFuaOZE3qgsg9KhNZoeP7FhbOvPEes8F1CmK cKxLhexoLEW7Q== In-Reply-To: <8634osdohs.fsf@gnu.org> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 740decd6a8f4124ecb07a0cce565b1e94e03fdd9 Received-SPF: pass client-ip=185.70.43.16; envelope-from=pipcet@protonmail.com; helo=mail-4316.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 03 Jul 2024 15:20:23 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321278 Archived-At: On Tuesday, July 2nd, 2024 at 11:25, Eli Zaretskii wrote: > > Date: Mon, 01 Jul 2024 21:08:07 +0000 >=20 > > From: Pip Cet pipcet@protonmail.com > > Cc: gerd.moellmann@gmail.com, yantar92@posteo.net, monnier@iro.umontrea= l.ca, emacs-devel@gnu.org, eller.helmut@gmail.com > >=20 > > Sorry, it took me a while to reproduce this because the default build w= orked fine, I had to --enable-checking to get something like your error, th= ough in my case it was clearly the set_weak_hash_hash_value call that was t= o blame. > >=20 > > I incorrectly assumed sxhash, Fsxhash, and the hash value in an equal-b= ased hash table were all the same number; in reality, sxhash is 32 bits on = a 32-bit system, 64 bits on a 64-bit system, Fsxhash is 30 bits on a 32-bit= system, 62 bits on a 64-bit system, and the hash value is 32 bits on all s= ystems. > >=20 > > Long story short, would you be able to try this patch and see whether y= ou get a clean dump? I do here... >=20 >=20 > Yes, this fixes the build, thanks. I've pushed a fix. I'm now doing precisely what Fsxhash does rather than si= mply trimming off bits until we fit into a fixnum. Thanks again Pip