From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Ludlam Newsgroups: gmane.emacs.devel Subject: Re: Towards a cleaner build: srecode/insert Date: Sun, 16 Jun 2019 10:19:30 -0400 Message-ID: <6f471e6f-b1cf-db31-72b1-e7bee8ac2b16@siege-engine.com> References: <831rzvvsgp.fsf@gnu.org> <83y322vqvg.fsf@gnu.org> <83v9x6vpap.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="239296"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 To: Lars Ingebrigtsen , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 16 16:23:26 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hcW45-001077-KN for ged-emacs-devel@m.gmane.org; Sun, 16 Jun 2019 16:23:25 +0200 Original-Received: from localhost ([::1]:40238 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcW44-0000Nb-Hx for ged-emacs-devel@m.gmane.org; Sun, 16 Jun 2019 10:23:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34078) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcW2U-0008CP-Lv for emacs-devel@gnu.org; Sun, 16 Jun 2019 10:21:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hcW0N-0003rI-4w for emacs-devel@gnu.org; Sun, 16 Jun 2019 10:19:36 -0400 Original-Received: from mail-qk1-f177.google.com ([209.85.222.177]:34449) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hcW0N-0003qB-0U for emacs-devel@gnu.org; Sun, 16 Jun 2019 10:19:35 -0400 Original-Received: by mail-qk1-f177.google.com with SMTP id t8so4713851qkt.1 for ; Sun, 16 Jun 2019 07:19:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RKnmdV5PpOpcY4pMh4CvdInxpFRAfIUOmNrZlb1emeU=; b=YAselLDHHFfPOiqThGNw0GRGsU6s+iF91G8Yf0BFnNrl4GuugoV7XjI1fDN3u/DcHz nI7kOY6jlN5arsk31YZURhxwJicdyPkyfajxw7lDBSDjgnHoU7MjDm2PFst6Lu541zRx MizA3vTCMOTuWU5iYQyFQ+oYF9xLhUvaNEyJFLEtsE6fZygdUaZNg91HWrKXKfa/CxG6 97/H8p9v/Kbap5+0kf6A2Boj3EGOuawB43zEwaxNwySlUR63GaJN/kHs6YsX8hsFNEwn cs1WZifsKdKReE2IYjbgTUHcRXRYrdNo9E1nV32Cu7HuLfThz1/xFJ7e0oJaZNqVesKY wjgw== X-Gm-Message-State: APjAAAUCPzaV1uCuzhZjqRnuSbTJVqXMdO9sM4BUIYcBncMrGLr1jurF 8N6wYz+k1GXiwrtA48CVt0ZJOYJdjOE= X-Google-Smtp-Source: APXvYqw9r09VJfgJcya3IEnmNlkG2z/TPGXYnCsZ1MDFnqx/N2IrWCG0qKi8uzND50bcnlbiD5H3jg== X-Received: by 2002:a37:4e92:: with SMTP id c140mr85324978qkb.48.1560694772571; Sun, 16 Jun 2019 07:19:32 -0700 (PDT) Original-Received: from [192.168.1.202] (pool-108-20-30-136.bstnma.fios.verizon.net. [108.20.30.136]) by smtp.googlemail.com with ESMTPSA id k55sm7184513qtf.68.2019.06.16.07.19.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 16 Jun 2019 07:19:31 -0700 (PDT) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.222.177 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237727 Archived-At: On 6/15/19 12:33 PM, Lars Ingebrigtsen wrote: > Is it literally complaining about that first parameter? > > (srecode-template-inserted-region :start 1 :end 2) > => #s(srecode-template-inserted-region # nil) > > (equal (srecode-template-inserted-region "TEMPLATE" :start 1 :end 2) > (srecode-template-inserted-region :start 1 :end 2)) > => t > > Indeed? The name arg is just discarded? In which case, it seems like > this could be fixed by just removing "TEMPLATE" from all these calls, > but that seems too obvious, so I'm asking. In old EIEIO, the first argument to a constructor was a name. I often used the name to distinguish between different instances. That way when debugging I could identify which object instance was which. Sometimes, such as above, there was no useful distinguishing name and a constant was used. If I remember rightly, the name isn't part of CLOS, so it was made optional, and now appears to be obsoleted. Since the only value of the name in most cases was for debugging, removing it should have no functional effect. The one exception is if the class in question inherits from 'eieio-named'. I'm not really sure how that might be made to work without the name input, and I don't have a recent enough Emacs to easily see how it was adapted. Hope this helps Eric