fix to make log-view.el work with svn

fix to make log-view.el work with svn

[Stephan Stahl]

Hi there..

lisp/log-view.el is said to work with svn but it does not work for me unless i patch these lines
(or change the variable by hand..).  Maybe someone wants to apply this change to the emacs
sources.

diff -c "log-view.el~" "log-view.el"
*** log-view.el~	Sat Aug 18 22:50:31 2007
--- log-view.el	Thu Jan 10 14:28:16 2008
***************
*** 143,149 ****
  (defvar log-view-message-face 'log-view-message)

  (defvar log-view-file-re
!   (concat "^\\(?:Working file: \\(?1:.+\\)"                ;RCS and CVS.
            ;; Subversion has no such thing??
            "\\|\\(?:SCCS/s\\.\\|Changes to \\)\\(?1:.+\\):" ;SCCS and Darcs.
  	  "\\)\n")                    ;Include the \n for font-lock reasons.
--- 143,149 ----
  (defvar log-view-message-face 'log-view-message)

  (defvar log-view-file-re
!   (concat "^\\(?:Working file\\(?:(s)\\)?: \\(?1:.+\\)"                ;RCS and CVS and Subversion.
            ;; Subversion has no such thing??
            "\\|\\(?:SCCS/s\\.\\|Changes to \\)\\(?1:.+\\):" ;SCCS and Darcs.
  	  "\\)\n")                    ;Include the \n for font-lock reasons.

Diff finished.  Thu Jan 10 14:28:16 2008


Regards,
Stephan

Re: fix to make log-view.el work with svn

[Glenn Morris]

"Stephan Stahl" wrote:

> lisp/log-view.el is said to work with svn but it does not work for
> me unless i patch these lines (or change the variable by hand..).
> Maybe someone wants to apply this change to the emacs sources.

What version of Emacs, and please give a recipe starting from -Q
showing a problem.

> !   (concat "^\\(?:Working file\\(?:(s)\\)?: \\(?1:.+\\)"                ;RCS and CVS and Subversion.

The current version of vc-svn in the CVS trunk uses "Working file"
(singular) AFAICS, so I don't see why that change would be needed.

Re: fix to make log-view.el work with svn

[Stephan Stahl]

Hi Glenn.

Glenn Morris wrote:

> "Stephan Stahl" wrote:
>
>> lisp/log-view.el is said to work with svn but it does not work for
>> me unless i patch these lines (or change the variable by hand..).
>> Maybe someone wants to apply this change to the emacs sources.
>
> What version of Emacs, and please give a recipe starting from -Q
> showing a problem.

Happend with:
GNU Emacs 23.0.0.1 (i386-mingw-nt5.1.2600) of 2007-08-18 on TPAD
  which is the 'current' one from http://ntemacs.sourceforge.net/
I just opened a file under svn control and did C-x v l and then pressed d to view the diff for the
last and previous version.
Result was:
log-view-current-file: Search failed: "^\\(?:Working file: \\(?1:.+\\)\\|\\(?:SCCS/s\\.\\|Changes
to \\)\\(?1:.+\\):\\)
"

> The current version of vc-svn in the CVS trunk uses "Working file"
> (singular) AFAICS, so I don't see why that change would be needed.

I did take a look at emacs-snapshot installed on my debian laptop and you are right vc-svn uses
"Working file" there!

GNU Emacs 23.0.50.1 (i486-pc-linux-gnu, GTK+ Version 2.12.3) of 2008-01-06 on eligiac, modified by
debian
  from http://emacs.orebokech.com


SO SORRY, guess i was too fast and will simply patch the file on my computer at work..

Regards and thanks for the quick response,
Stephan