From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: Undo mode Date: Fri, 21 Jan 2022 15:07:12 +0000 Message-ID: <6d8355dee1739ebeed3d@heytings.org> References: <86tudyw1ir.fsf@mail.linkov.net> <86iludijyi.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2455"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, Juri Linkov To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 21 16:09:47 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nAvXu-0000Vy-UI for ged-emacs-devel@m.gmane-mx.org; Fri, 21 Jan 2022 16:09:47 +0100 Original-Received: from localhost ([::1]:55502 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nAvXt-0000PX-5p for ged-emacs-devel@m.gmane-mx.org; Fri, 21 Jan 2022 10:09:45 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38832) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAvVU-0007Wx-Ct for emacs-devel@gnu.org; Fri, 21 Jan 2022 10:07:16 -0500 Original-Received: from heytings.org ([95.142.160.155]:35482) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAvVS-0003cI-Om for emacs-devel@gnu.org; Fri, 21 Jan 2022 10:07:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1642777632; bh=gTdKK8gyvo2yBTUXp6FPBflSAiKjVbKj4d4+SdpF7iE=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=Myfim102F/0Acdi8HR3EyF+V0upeMfoQRqzfDLtmAZBO4SdW2ogR2sj+t6/8iSy2Y Dhi3Ljx6r3o1SGMh5JCBDYZlwfF7CItVZqX64U7INItutF/aEyrpzpb1MMVrN1yxJN OOdAgMwQo3Ri7hcHtQhXg+JQiSTCCydYotawze6ZNmVtHV2bFuwi0qLoPLNHZ4YnTM Pa58L3t9fap6QnpjpAez41kUGAIZAm+pExng81pY0qclTwx9KwX8j5GY/kJ9Y4HWEl hHb8GdmMg5ii/9OaHl9CgVyR2z5qwB0bVAQ/Yi5YlNI2Dg1PLCoYjWvawVka6PA3IW zvNQpLFj9iKtw== In-Reply-To: Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285144 Archived-At: > > I think it's better to add a specific workaround in > `undelete-frame--handle-delete-frame` such as: > > (unless (eq frame frame-initial-frame) ...) > > And if that specific one doesn't work, we'll come up with a different > test. > That problem was already identified and solved (with a boolean state variable) in bug#51883, before the current solution (using a minor mode that users can turn on in their init file) was adopted. With a minor mode this test becomes unnecessary.