unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Dmitry Antipov <dmantipov@yandex.ru>,
	Emacs development discussions <emacs-devel@gnu.org>
Subject: RE: One more string functions change
Date: Fri, 27 Jun 2014 15:46:33 -0700 (PDT)	[thread overview]
Message-ID: <6cf80ae5-a4ad-4839-adfd-14bf973f056f@default> (raw)
In-Reply-To: <53AD8D59.5000207@yandex.ru>

> (defun gnus-string< (s1 s2)
>    "..."
>    (if case-fold-search
>        (string-lessp (downcase (if (symbolp s1) (symbol-name s1) s1))
>                      (downcase (if (symbolp s2) (symbol-name s2) s2)))
>      (string-lessp s1 s2)))

Why?  Is (string-lessp s1 s2 t) really that much handier than being
explicit?

(let ((case-fold-search  t)) (string-lessp s1 s2))

or

(string-lessp (upper s1) (upper s2))

We already have a global variable for this.  Why add an argument for it?

And if you want to accept symbols too as args, then "string-lessp" is
anyway a poor name for what it does.

This is no different from lots of other uses of a function that binds
a global var, or converts/casts its args, to change its behavior.

How many occurrences of such a programming cliche for `string-lessp'
do you find in the Emacs sources, for example?  One?  Zero?

YAGNI.



  parent reply	other threads:[~2014-06-27 22:46 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-27 15:27 One more string functions change Dmitry Antipov
2014-06-27 15:35 ` Andreas Schwab
2014-06-27 16:46 ` Paul Eggert
2014-06-27 19:46   ` Eli Zaretskii
2014-06-27 20:46     ` Paul Eggert
2014-06-27 20:53       ` Eli Zaretskii
2014-06-28 16:21     ` Dmitry Antipov
2014-06-28 17:19       ` Eli Zaretskii
2014-06-29  2:53         ` Dmitry Antipov
2014-06-29 15:13           ` Eli Zaretskii
2014-06-29 16:38             ` Dmitry Antipov
2014-06-29 16:48               ` Eli Zaretskii
2014-06-30  6:21                 ` Internationalize Emacs's messages [Was: Re: One more string functions change] Dmitry Antipov
2014-06-28 17:26       ` One more string functions change Yuri Khan
2014-06-27 22:46 ` Drew Adams [this message]
2014-06-28  3:48   ` Dmitry Antipov
2014-06-28 13:48     ` Drew Adams
2014-06-28 16:32       ` Dmitry Antipov
2014-06-30 13:18     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6cf80ae5-a4ad-4839-adfd-14bf973f056f@default \
    --to=drew.adams@oracle.com \
    --cc=dmantipov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).