From: Alexander Shukaev <emacs@Alexander.Shukaev.name>
To: Juri Linkov <juri@linkov.net>
Cc: emacs-devel@gnu.org
Subject: Re: `isearch-complete1' should use `completion-at-point' or `completion-in-region'
Date: Mon, 13 Jan 2020 15:35:09 +0100 [thread overview]
Message-ID: <6cccab0c-b693-67ea-b723-403684d70ab2@Alexander.Shukaev.name> (raw)
In-Reply-To: <8736ckl015.fsf@mail.linkov.net>
On 13/01/2020 00:36, Juri Linkov wrote:
>> Not sure why in the first place `isearch-complete1' uses some custom
>> auto-completion implementation that is different from a conventional
>> solution, perhaps historical reasons. Thus, I believe that reusing either
>> `completion-at-point' or `completion-in-region' to implement that
>> functionality is much better in the long run. This would also allow
>> packages, which customize completion behavior, to hook into `isearch'
>> auto-completion as well. See also [1] for example.
>>
>> [1] https://github.com/abo-abo/swiper/issues/1882
>
> Indeed, Isearch uses custom completion for historical reasons,
> and there is no reason for this anymore.
>
> But there is one thing I don't understand: how packages prefer to hook
> into auto-completion? Is it enough to convert `isearch-complete1' to
> just `completing-read' in the minibuffer activated by `isearch-edit-string'?
>
Exactly, e.g. `ivy' [1] would pick it up out of the box.
[1] https://github.com/abo-abo/swiper/blob/master/ivy.el
next prev parent reply other threads:[~2020-01-13 14:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7da1738e-1e8a-3c12-31bf-741ee171db5c@Alexander.Shukaev.name>
2020-01-12 23:36 ` `isearch-complete1' should use `completion-at-point' or `completion-in-region' (was: bug#39015) Juri Linkov
2020-01-13 14:35 ` Alexander Shukaev [this message]
2020-01-13 19:38 ` `isearch-complete1' should use `completion-at-point' or `completion-in-region' Stefan Monnier
2020-01-14 23:51 ` Juri Linkov
2020-01-15 13:57 ` Stefan Monnier
2020-01-15 23:24 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cccab0c-b693-67ea-b723-403684d70ab2@Alexander.Shukaev.name \
--to=emacs@alexander.shukaev.name \
--cc=emacs-devel@gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).