From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: esh-proc test failures Date: Tue, 30 Aug 2022 09:51:01 -0700 Message-ID: <6ca75c4c-adfc-fdde-cbff-6c76db036eab@gmail.com> References: <166036758418.2203.8730240669199078524@vcs2.savannah.gnu.org> <20220813051305.6667BC09BFE@vcs2.savannah.gnu.org> <87o7wmg0nx.fsf_-_@gnus.org> <30a7e3aa-ad52-325f-4fcd-528aade4a339@gmail.com> <838rng9kes.fsf@gnu.org> <837d2zae3m.fsf@gnu.org> <83v8qj8a2y.fsf@gnu.org> <83v8qj6iay.fsf@gnu.org> <40db52f2-86f1-3e86-fbca-80a8be09ee66@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6645"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 30 18:57:21 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oT4YD-0001bU-IP for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 18:57:21 +0200 Original-Received: from localhost ([::1]:58520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oT4YB-00023H-Ct for ged-emacs-devel@m.gmane-mx.org; Tue, 30 Aug 2022 12:57:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36570) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oT4SD-00036c-AB for emacs-devel@gnu.org; Tue, 30 Aug 2022 12:51:09 -0400 Original-Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]:38681) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oT4S8-0008Eq-Ql; Tue, 30 Aug 2022 12:51:08 -0400 Original-Received: by mail-pj1-x1030.google.com with SMTP id x1-20020a17090ab00100b001fda21bbc90so8122012pjq.3; Tue, 30 Aug 2022 09:51:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :date:message-id:references:cc:to:from:subject:from:to:cc; bh=oXV0qrO8BzeayDYIS/AMB6n4gZgMbyGpu+BHvHEehgQ=; b=h6gVB9AcHMnBdLyX2XxQMksyReXd8yxsfnUxtL9OBF8XJq0+3DFMqaa5bvp2Yo4ipo 1LBp7gp0pv49JyYRo8DSQEnwioaj88Rg1Huq9S34CLCf4eGuRkt5229RQsnE6czlgrVs gJLfj1tCHKFlV6rTG4OgZBF5LmcFO37Kybz72iD63Y2NKEgSdPkQC8+uvZu+efmRmitB nW05004Uah0OL4lrnO7HSmI/gUDfZfj2o5fXVvGmUl0xeibM1J6U4xW5mxhMod/3kd1p zkaZyeEhRFR/ascl2e0ys5NDMDIUCG/Yz2bF/p66AxXuOD35FPgwQL6NYoBLmU17HxGq cnSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :date:message-id:references:cc:to:from:subject:x-gm-message-state :from:to:cc; bh=oXV0qrO8BzeayDYIS/AMB6n4gZgMbyGpu+BHvHEehgQ=; b=n2DVmmvNDWDeVHL3iHqYoFHSALPvPIBaZd0urEX6LSnfGnRE5hgBBvNnteRVbkoyvK 8pUJXQKgnqZL90hDACiMr/TPhogx7QDhulyZxC58ZsyXv6pCdO8sMlahOClp8yVe2pSM UQz7wL7Y5oBfDKUiRy8CUmKtS/bnQoufkYNHGMniIgC87KnBhhL3cK+lZYzXH4RE3JOR 8/2pNOY3Q/ePQUN3X3/R2UKvHDNTzRnAMa954pdyeyUZst7HC8X/rtffLNRzHp9FUgPO B1JfNE2cDlkU1QZLPMSSKKC1XZYd8Ci7bsxnp3Ig6sUZnCvoKmRh3JpEWKwxrA/x6K/T 5p6g== X-Gm-Message-State: ACgBeo2MHJD8a1xUFJlYRY9+/76bJ4jlQeUHnSoGmZVA/MOcHrmO5UAc cMDn/+6e2IQtEbqMahvRkaBgtIFpQoU= X-Google-Smtp-Source: AA6agR7sgLiISbWsjrV3Rdt1ZUpaiCW3dopTKaoYjRtvFa4u9B7vLeW9eoK6/8aAaYvluzp89mbKHA== X-Received: by 2002:a17:902:a583:b0:174:d767:8393 with SMTP id az3-20020a170902a58300b00174d7678393mr9082228plb.8.1661878261820; Tue, 30 Aug 2022 09:51:01 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id b14-20020aa78ece000000b0052d98fbf8f3sm9589687pfr.56.2022.08.30.09.50.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Aug 2022 09:51:00 -0700 (PDT) In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=2607:f8b0:4864:20::1030; envelope-from=jporterbugs@gmail.com; helo=mail-pj1-x1030.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294359 Archived-At: On 8/29/2022 8:18 PM, Jim Porter wrote: > On 8/23/2022 9:38 AM, Jim Porter wrote: >> Then I think we're in agreement, since that's what Eshell currently >> does. (My sentence above was just trying to say that, *somehow*, >> Eshell needs to be sure that the relevant process is informed of the >> error. Delivering a signal is how Eshell does it now, and I think >> that's ok.) > > Merged as f9250c5ebc1730bf3bed4382549433f52f7ef9ca. Hopefully this fixes > EMBA; if there are any further issues anyone encounters, just let me know. Apparently it doesn't. I've confirmed again locally that my patch does fix *an* issue with 'eshell-pipe-broken', but I guess it's not the same issue as what's on EMBA. I'll see if I can fix EMBA for real, or failing that, we can disable the tests again.