From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: emacs.pdmp not always rebuilt Date: Mon, 04 Oct 2021 13:25:03 +0000 Message-ID: <6c697805389a800abc59@heytings.org> References: <87h7dyqo02.fsf@gnus.org> <83k0iu8e2u.fsf@gnu.org> <87czomqmn6.fsf@gnus.org> <878rzaqilg.fsf@gnus.org> <83pmsl7cc9.fsf@gnu.org> <6c69780538e7dcf21be8@heytings.org> <83fsth6jjr.fsf@gnu.org> <6c697805381c56ec6eda@heytings.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2632"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 04 15:27:50 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mXO0S-0000Ph-6P for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Oct 2021 15:27:48 +0200 Original-Received: from localhost ([::1]:43408 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXO0R-00045p-7j for ged-emacs-devel@m.gmane-mx.org; Mon, 04 Oct 2021 09:27:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33562) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXNxs-0001Kd-9P for emacs-devel@gnu.org; Mon, 04 Oct 2021 09:25:08 -0400 Original-Received: from heytings.org ([95.142.160.155]:36842) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXNxq-0007o4-GB; Mon, 04 Oct 2021 09:25:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1633353903; bh=MbKnalXagTiB+1jzHzrDCfIBJlE+4v9dShTsJQErZic=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=YNqUTZ59p33LJ4xS9bBXs65yVr2MJf2KUEY2EwfxR/2nmISzsfS2m/SNzsg66V4B0 wqWBSXmG4aRBPSgd1oSuKyhqBwvQ8nXiVBH9LRpO+lFKUx9yi6J0EoVfAdV3igwVa9 Xn3muJxGWQ8oZ5Hkk49yCLmTgxZN+trZ+EGyUKi43LoCBCL1yjAifMofIJ82gvL57E AtXHB6OvEQ3ReEgPbnsQY9GgGGpQsG4NMhlYhMuHjjq/9o+EfDjPEJ1YbDlgEIXC/V fIu6LVVR4/AwdXdDcuq0LvnzhHz9/DQOEqBX0QaqVGZCtUM3bwT6SIGzD8v4zBtQ7o nXV5eDQLqzvGw== In-Reply-To: <6c697805381c56ec6eda@heytings.org> Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:276186 Archived-At: >> or simply test if substitute-command-keys is fboundp, and avoid using >> it if not. > > That would be another option, yes. I don't think it's much better > though, as Stefan K said a few hours ago the potential effect on > substitute-command-keys on error messages during the build is minor. > And after thinking a few seconds more about this, IMO it would not be a better option: the fact that substitute-command-keys is fboundp does not guarantee that it will work correctly, because it could be the function that is currently being debugged or updated. So IMO it's better to simply avoid using substitute-command-keys on error messages during bootstrap, which is what the patch does.