From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Eglot, project.el, and python virtual environments Date: Sat, 19 Nov 2022 03:12:21 +0200 Message-ID: <6c389018-092f-9466-8f72-cf97d33adca2@yandex.ru> References: <87zgcq68zp.fsf@ericabrahamsen.net> <878rkale3l.fsf@dfreeman.email> <87v8nezf2k.fsf@ericabrahamsen.net> <87o7t5k7sv.fsf@dfreeman.email> <86mt8p4221.fsf@gmail.com> <4cc918a053771a5e1c440cb4b458f3ed@webmail.orcon.net.nz> <838rk8d7xb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29920"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Cc: theophilusx@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii , Phil Sainty Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 19 02:13:36 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owCQK-0007dp-HL for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Nov 2022 02:13:36 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owCPa-00054g-ME; Fri, 18 Nov 2022 20:12:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owCPV-000537-Vr for emacs-devel@gnu.org; Fri, 18 Nov 2022 20:12:46 -0500 Original-Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1owCPT-0006ov-Dj; Fri, 18 Nov 2022 20:12:45 -0500 Original-Received: by mail-wr1-x42f.google.com with SMTP id cl5so11864678wrb.9; Fri, 18 Nov 2022 17:12:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=KbrIU4/cX6N/NA0VsfMx1LYDstbj7t6Jy3J3K0BuBeU=; b=avIJ7w1XOrUZEdfuhdi7Va/sRu2I8pukW7YrAkBG74d/4y+UL5Mf+sJkXe9gHZTS/U vPbR3dw3q84hWKU1BgLCojhUzUXe4g19Bl1rbzUy90myUqSozvTX1U1WFitLomA0DhtI N4FHRVV7uEK5LfgsqEMLbAreuiJPAbOxpG6Vrzc2FQHV5jWi8gwhINCUbM/ntfm3wD0i C+xEf9RU7ZvhtaVwrxKUzIkONKkMA1wEB05WkB6F8hV1og4sSh1ebTvZMufTxMXeKtB7 wflU62zYnKRAAKc/5Q2nGVblxkkgdhPZsaORCdOfDyCDmT40AIrofC1U36vmJKQWVi4R xvNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KbrIU4/cX6N/NA0VsfMx1LYDstbj7t6Jy3J3K0BuBeU=; b=tccUz3HP1eiODI1357xpf+4PguobAWZbctD2ybuuIROM8mqUAILqn6GdZO+7EadTBZ n6Y9NnWDw/V4psgusPNHceYDykSquOyYklXxYfw/r69VT4uD/xbhda4oxSQo7XbyO8+5 c1RgweplZj/+RiNDg1//z0Vx4lSiXZYC50KDNlbuQ8X/14UjFikdSLDqo/pVErL0Qroh L9ofWLJYoM/OSi3AzUzOD9snK+gwIdxiheAPO7VMmnySZdvU0G8fNhj5Y1tMDTspU8Xz dPnsTEdBQi4dSrxo1uC3xl2IDnLMLZFRd9ddh+2zB5je+iwzVtfJHppBabDWTCTIEc2t hsYQ== X-Gm-Message-State: ANoB5pmiGRYL3kO2s4EynML6UelnhfOZqheOQ7IfvAih5uWG0IfnUvbh Nu/NH02Fq1a5ANn5npyG5ALvpwkqW48= X-Google-Smtp-Source: AA0mqf4W8yV4NIKhXvs2NNi1/hxcJBFTJy3FMqNkWKmrBo9dfGGgUh35F3dLCYB9LX6Ua6VlLUIbDg== X-Received: by 2002:a5d:4812:0:b0:236:88e2:2321 with SMTP id l18-20020a5d4812000000b0023688e22321mr5287383wrq.506.1668820344794; Fri, 18 Nov 2022 17:12:24 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id l18-20020a05600c4f1200b003c6f3f6675bsm11453389wmq.26.2022.11.18.17.12.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Nov 2022 17:12:24 -0800 (PST) Content-Language: en-US In-Reply-To: <838rk8d7xb.fsf@gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=raaahh@gmail.com; helo=mail-wr1-x42f.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300130 Archived-At: On 18.11.2022 09:43, Eli Zaretskii wrote: > Another evidence that this should be solved in Eglot is that "the > other LSP mode" doesn't depend on project for this. FWIW, "the other LSP mode" just provides more choices for the user in general, which is in line with its overall design. > I would also like to hear from Dmitry what are his thoughts on this. That's my inclination as well, based on the requested behavior in this thread. We do have an old feature request in bug#54228 (which I'm hoping to resolve soon enough; more voices in that discussion would be welcome, by the way), but it can only be an answer here if people are okay with the "subprojects" behaving like separate projects altogether (meaning, for example, that project-find-file only offers files from the current subproject to jump). Or else, we'd have a new notion of subprojects, and a separate set of commands to navigate/search/replace/etc in such. Not sure if that's what people want either. And if not (to both), the proposed fixes using project-find-functions are not a good fit too. Then I suppose Eglot could just learn a set of markers of its own (e.g. files named .eglot and/or build file names of popular tools). Not sure if LSP recommends something in that regard, or just defers to the editors. I wonder how VS Code and NeoVim, etc, make this decision.