From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: master 2ed2999: Improve documentation of new Xref options
Date: Tue, 7 Sep 2021 18:24:46 +0300 [thread overview]
Message-ID: <6b688b48-eae7-1dbc-3de6-97f071583659@yandex.ru> (raw)
In-Reply-To: <83h7ewpmc4.fsf@gnu.org>
On 07.09.2021 16:05, Eli Zaretskii wrote:
>> Or "commands which display many matches, with high likelihood that the
>> user will want to visit every match, rather than just pick one". At
>> least that was the thinking behind xref-show-definitions-function vs
>> xref-show-xrefs-function.
>
> OK, I hope I fixed this stuff now, please take a look.
Thank you, sent some comments.
You didn't seem to adopt the suggested description, but OK.
>>>>> And what about stuff like
>>>>> dired-do-find-regexp-and-replace -- is that affected by any of these?
>>>>
>>>> dired-do-find-regexp-and-replace is affected as well right now, but
>>>> that's a bug to be fixed (thanks for bringing it up).
>>>
>>> I see you fixed that already, but what about dired-do-find-regexp?
>>
>> It's in the same category as xref-find-references and others. Should
>> work fine already.
>
> Should we perhaps treat dired-do-find-regexp like we do with
> dired-do-find-regexp-and-replace, to avoid confusion due to
> inconsistency?
dired-do-find-regexp-and-replace is a totally different command, which
could use an entirely different UI (as soon as someone wrote one).
There is no way to have it obey xref-auto-jump-to-first-xref: it simply
failed to work without the fix.
next prev parent reply other threads:[~2021-09-07 15:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210905075953.20536.20920@vcs0.savannah.gnu.org>
[not found] ` <20210905075955.0F6B720A0A@vcs0.savannah.gnu.org>
2021-09-05 19:38 ` master 2ed2999: Improve documentation of new Xref options Dmitry Gutov
2021-09-06 4:30 ` Eli Zaretskii
2021-09-06 11:24 ` Dmitry Gutov
2021-09-06 12:28 ` Eli Zaretskii
2021-09-06 12:47 ` Dmitry Gutov
2021-09-06 15:33 ` Eli Zaretskii
2021-09-06 15:43 ` Dmitry Gutov
2021-09-07 13:05 ` Eli Zaretskii
2021-09-07 15:24 ` Dmitry Gutov [this message]
2021-09-07 15:27 ` Dmitry Gutov
2021-09-07 16:07 ` Eli Zaretskii
2021-09-07 15:47 ` Eli Zaretskii
2021-09-07 16:01 ` Dmitry Gutov
2021-09-07 16:18 ` Eli Zaretskii
2021-09-07 16:27 ` Dmitry Gutov
2021-09-07 17:03 ` [External] : " Drew Adams
2021-09-07 17:21 ` Dmitry Gutov
2021-09-07 17:28 ` Drew Adams
2021-09-07 17:40 ` Dmitry Gutov
2021-09-07 19:44 ` Drew Adams
2021-09-07 20:08 ` ARG and Dired commands, was: " Dmitry Gutov
2021-09-07 20:42 ` Drew Adams
2021-09-07 20:49 ` Dmitry Gutov
2021-09-07 21:47 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b688b48-eae7-1dbc-3de6-97f071583659@yandex.ru \
--to=dgutov@yandex.ru \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).