From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Require full GMP for big integer module functions. Date: Sun, 28 Apr 2019 13:18:37 -0700 Organization: UCLA Computer Science Department Message-ID: <6b1d4cd0-a86e-dc76-d90a-1456fbd75a80@cs.ucla.edu> References: <83y33yxdsc.fsf@gnu.org> <20190425170904.99105-1-phst@google.com> <9cadbf09-0101-d2bf-b45a-5cbaed692bbb@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="82297"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Cc: Philipp Stephani , Emacs developers To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 28 22:28:41 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hKqPg-000LJH-Pa for ged-emacs-devel@m.gmane.org; Sun, 28 Apr 2019 22:28:40 +0200 Original-Received: from localhost ([127.0.0.1]:48111 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKqPf-0007bD-Oe for ged-emacs-devel@m.gmane.org; Sun, 28 Apr 2019 16:28:39 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60077) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKqPX-0007Sg-Ss for emacs-devel@gnu.org; Sun, 28 Apr 2019 16:28:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hKqG2-0000Bx-73 for emacs-devel@gnu.org; Sun, 28 Apr 2019 16:18:43 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:57088) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hKqG2-0000Ac-1P for emacs-devel@gnu.org; Sun, 28 Apr 2019 16:18:42 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 72AE4161836; Sun, 28 Apr 2019 13:18:39 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 0rTVXhYe1PlD; Sun, 28 Apr 2019 13:18:38 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 9B023161834; Sun, 28 Apr 2019 13:18:38 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ri1dVS0s8heS; Sun, 28 Apr 2019 13:18:38 -0700 (PDT) Original-Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 6E1741616EA; Sun, 28 Apr 2019 13:18:38 -0700 (PDT) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236013 Archived-At: Philipp Stephani wrote: > if emacs-mini-gmp.h ever > becomes incompatible, the behavior will silently become undefined, There is no emacs-mini-gmp.h so I assume you mean Emacs's src/mini-gmp.h. That file is identical to GMP's mini-gmp.h, so isn't the Emacs-relevant incompatibility the same as the incompatiblity that the GMP maintainers are worried about? > My understanding is that emacs-mini-gmp.h is > maintained as part of Emacs They're identical to the GMP mini-gmp.c and mini-gmp.h so they're primarily maintained as part of GMP. The only part relevant to Emacs maintenance is that when we update Emacs src/mini-gmp.h and src/mini-gmp.c from GMP sources, we should look for Emacs-relevant incompatibilities and if there are any (which typically there are not) we should delay these updates until the next Emacs release. But this is something we should do anyway - it's an ordinary part of release maintenance. There's an analogy to Gnulib here. At some point after forking emacs-26 from the master branch, we stopped propagating Gnulib patches into emacs-26 because they were considered too likely to break what was intended to be a stable branch. If mini-gmp had been part of Emacs 26, I expect we would have taken the same approach to mini-gmp as well. Which reminds me, now's as good time as any to sync Emacs master to the latest GMP copies of mini-gmp.h and mini-gmp.c, so I did that.