From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: master 1069364 2/2: Simplify by using attribute.h macros Date: Tue, 5 May 2020 17:23:30 -0700 Organization: UCLA Computer Science Department Message-ID: <6b0e6c81-bf20-5830-f729-68d8df8b3a97@cs.ucla.edu> References: <20200503221011.6736.42592@vcs0.savannah.gnu.org> <20200503221015.4C8AF20B5B@vcs0.savannah.gnu.org> <87d07ikgxv.fsf@igel.home> <9a29d3e5-9181-255b-7ccb-cdd96a08c48b@cs.ucla.edu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------97B75F97318DDDA494A582AD" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="110993"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 06 02:24:10 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jW7r6-000Shw-9N for ged-emacs-devel@m.gmane-mx.org; Wed, 06 May 2020 02:24:08 +0200 Original-Received: from localhost ([::1]:33314 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jW7r5-0006oo-C6 for ged-emacs-devel@m.gmane-mx.org; Tue, 05 May 2020 20:24:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59152) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jW7qc-0006Pq-82 for emacs-devel@gnu.org; Tue, 05 May 2020 20:23:38 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:34048) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jW7qa-0008I2-Jv; Tue, 05 May 2020 20:23:37 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B663F160079; Tue, 5 May 2020 17:23:31 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ssplNWyjE8hV; Tue, 5 May 2020 17:23:30 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id BCEC5160085; Tue, 5 May 2020 17:23:30 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id dpL2o2QEq9qa; Tue, 5 May 2020 17:23:30 -0700 (PDT) Original-Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 88AF7160079; Tue, 5 May 2020 17:23:30 -0700 (PDT) Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= LS0tLS1CRUdJTiBQR1AgUFVCTElDIEtFWSBCTE9DSy0tLS0tCgptUUlOQkV5QWNtUUJFQURB QXlIMnhvVHU3cHBHNUQzYThGTVpFb243NGRDdmM0K3ExWEEySjJ0QnkycHdhVHFmCmhweHhk R0E5Smo1MFVKM1BENGJTVUVnTjh0TFowc2FuNDdsNVhUQUZMaTI0NTZjaVNsNW04c0thSGxH ZHQ5WG0KQUF0bVhxZVpWSVlYL1VGUzk2ZkR6ZjR4aEVtbS95N0xiWUVQUWRVZHh1NDd4QTVL aFRZcDVibHRGM1dZRHoxWQpnZDdneDA3QXV3cDdpdzdlTnZub0RUQWxLQWw4S1lEWnpiRE5D UUdFYnBZM2VmWkl2UGRlSStGV1FONFcra2doCnkrUDZhdTZQcklJaFlyYWV1YTdYRGRiMkxT MWVuM1NzbUUzUWpxZlJxSS9BMnVlOEpNd3N2WGUvV0szOEV6czYKeDc0aVRhcUkzQUZINmls QWhEcXBNbmQvbXNTRVNORnQ3NkRpTzFaS1FNcjlhbVZQa25qZlBtSklTcWRoZ0IxRApsRWR3 MzRzUk9mNlY4bVp3MHhmcVQ2UEtFNDZMY0ZlZnpzMGtiZzRHT1JmOHZqRzJTZjF0azVlVThN Qml5Ti9iClowM2JLTmpOWU1wT0REUVF3dVA4NGtZTGtYMndCeHhNQWhCeHdiRFZadWR6eERa SjFDMlZYdWpDT0pWeHEya2wKakJNOUVUWXVVR3FkNzVBVzJMWHJMdzYrTXVJc0hGQVlBZ1Jy NytLY3dEZ0JBZndoU In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=131.179.128.68; envelope-from=eggert@cs.ucla.edu; helo=zimbra.cs.ucla.edu X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/05 20:23:31 X-ACL-Warn: Detected OS = Linux 3.1-3.10 X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:249062 Archived-At: This is a multi-part message in MIME format. --------------97B75F97318DDDA494A582AD Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 5/5/20 10:11 AM, Glenn Morris wrote: > emacs-module.c:252:3: error: #error "__attribute__ ((cleanup)) not > supported by this compiler; try GCC" > #error "__attribute__ ((cleanup)) not supported by this compiler; try GCC" > ^ Thanks, I installed the attached. --------------97B75F97318DDDA494A582AD Content-Type: text/x-patch; charset=UTF-8; name="0001-Don-t-assume-__has_attribute-in-emacs-module.c.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-Don-t-assume-__has_attribute-in-emacs-module.c.patch" >From 4658a44f1464c274f377f593717b1a40bbfd47e5 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Tue, 5 May 2020 17:16:49 -0700 Subject: [PATCH] =?UTF-8?q?Don=E2=80=99t=20assume=20=5F=5Fhas=5Fattribute?= =?UTF-8?q?=20in=20emacs-module.c?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Problem reported by Glenn Morris in: https://lists.gnu.org/r/emacs-devel/2020-05/msg00724.html * src/emacs-module.c: Use HAS_ATTRIBUTE instead of assuming the compiler supports __has_attribute. --- src/emacs-module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/emacs-module.c b/src/emacs-module.c index e43e4907d2..3d1827c7da 100644 --- a/src/emacs-module.c +++ b/src/emacs-module.c @@ -248,7 +248,7 @@ module_decode_utf_8 (const char *str, ptrdiff_t len) of `internal_condition_case' etc., and to avoid worrying about passing information to the handler functions. */ -#if !__has_attribute (cleanup) +#if !HAS_ATTRIBUTE (cleanup) #error "__attribute__ ((cleanup)) not supported by this compiler; try GCC" #endif -- 2.17.1 --------------97B75F97318DDDA494A582AD--