From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 4) Date: Sat, 8 May 2021 11:10:59 +0200 Message-ID: <6ac36d0f-bf5b-2124-1f70-69644bb40218@daniel-mendler.de> References: <0bbdeece-90d5-160c-07ec-2ad8edbf9872@daniel-mendler.de> <87czudm7bv.fsf@mail.linkov.net> <976056e8-3d46-db27-32c2-ddf3ca32d5a7@daniel-mendler.de> <878s5090e9.fsf@mail.linkov.net> <69fd42ed-a1a0-adcb-ac8b-caad80cb0967@daniel-mendler.de> <878s4zzpvc.fsf@mail.linkov.net> <95ac7ef3-5e8c-fc58-b316-544096c82aa0@daniel-mendler.de> <87o8dus00b.fsf@mail.linkov.net> <6718c89f-88a0-b529-1676-7e89fc152f00@daniel-mendler.de> <878s4w3law.fsf@mail.linkov.net> <87sg2ymq6j.fsf@mail.linkov.net> <78bb0663-80ef-a68f-c582-cd7cc0436c29@daniel-mendler.de> <069cec7d-db2c-8628-69fb-a2aee4ee5074@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23959"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Gregory Heytings , "emacs-devel@gnu.org" , Stefan Monnier , Dmitry Gutov To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 08 11:12:03 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfJ0F-00068c-SV for ged-emacs-devel@m.gmane-mx.org; Sat, 08 May 2021 11:12:03 +0200 Original-Received: from localhost ([::1]:49276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lfJ0E-0002IZ-Q8 for ged-emacs-devel@m.gmane-mx.org; Sat, 08 May 2021 05:12:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfIzL-0001cw-JP for emacs-devel@gnu.org; Sat, 08 May 2021 05:11:07 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:55155 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfIzI-0000jt-NY for emacs-devel@gnu.org; Sat, 08 May 2021 05:11:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:References:Cc:To:From:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=y/cRPwbzycG32yEIgV9WCkuTW1CwxCbTC1BfHp+T78A=; b=hMXxvHZelvKohzPMEqVADaShVl 7aWR5CYFpIPiC6WlT2AFkaHP4Rv+An8PvAUuZVObWG2JBPj5twRsrzZuBpzAuK5yn1u8gJKX1YgjQ vVLyg3VnHuqKF8efICG8H1iJogQA94ToagSoH5lN6GKSPAhb62D/LLhwJhIvHk03M700=; In-Reply-To: <069cec7d-db2c-8628-69fb-a2aee4ee5074@daniel-mendler.de> Content-Language: en-US Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269031 Archived-At: On 5/8/21 10:45 AM, Daniel Mendler wrote: > On 5/8/21 8:24 AM, Daniel Mendler wrote: >> On 5/7/21 7:55 PM, Daniel Mendler wrote: >>> On 5/7/21 7:03 PM, Juri Linkov wrote: >>>> I tried to remove `read-char-by-name-group`, but it has a feature >>>> currently not supported by `group-function`: >>>> >>>> (defcustom read-char-by-name-group nil >>>> "How to group characters for `read-char-by-name' completion. >>>> When t, split characters to sections of Unicode blocks >>>> sorted alphabetically." >>>> ===================== >>>> >>>> It seems a new function is needed to sort groups, e.g. `group-sort-function`. >> >> 3. Use a single function with an action argument >> 3.1 group-function : (action=title) -> string -> string >> 3.2 group-function : (action=transform) -> string -> string >> 3.3 group-function : (action=sort) -> list string -> list string > I attached the current set of patches. The last patch > "0005-group-function-Implement-generalized-action-argument.patch" > implements the generalized action argument. The other patches (1-4) do > not differ from the previously sent patches. I send them for completeness. Correction to the lastest patch. The `minibuffer--group-by` function should actually be written as follows: (defun minibuffer--group-by (group-fun elems) "Group ELEMS by GROUP-FUN." (let ((groups)) (dolist (cand elems) (let* ((key (funcall group-fun 'title cand)) (group (assoc key groups))) (if group (setcdr group (cons cand (cdr group))) (push (list key cand) groups)))) ;; FIXME: Is thread-last allowed in minibuffer.el? (setq groups (nreverse groups) groups (mapc (lambda (x) (setcdr x (nreverse (cdr x)))) groups) groups (funcall group-fun 'sort groups) groups (mapcar #'cdr groups)) (apply #'nconc groups))) Daniel