From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action' Date: Thu, 30 Dec 2021 09:34:41 +0100 Message-ID: <6a9cd581-1630-4a95-62c4-419603561072@gmx.at> References: <164073060906.21430.4993248796177370312@vcs2.savannah.gnu.org> <20211228223009.6D0BAC002EE@vcs2.savannah.gnu.org> <871r1v8nhf.fsf@gnus.org> <83ilv7jqm7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6600"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sdsg@amazon.com, emacs-devel@gnu.org To: Eli Zaretskii , Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 30 09:36:52 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n2qvc-0001YW-QM for ged-emacs-devel@m.gmane-mx.org; Thu, 30 Dec 2021 09:36:52 +0100 Original-Received: from localhost ([::1]:60972 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n2qvb-0008Ij-H9 for ged-emacs-devel@m.gmane-mx.org; Thu, 30 Dec 2021 03:36:51 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2qth-0006q2-Oe for emacs-devel@gnu.org; Thu, 30 Dec 2021 03:34:54 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]:55381) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2qtf-0000Pu-Al; Thu, 30 Dec 2021 03:34:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1640853282; bh=LVRzPGmoMMHBZtxSDyQbF5COPltQNaNxUZNH/0W6lhA=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=C2nHvSiU1peUX9x7pIrIvPhtzhMb1asKx8iFZROp+E0eNMDWk0aYG4KtojnFxzbUc TaSolPkp1JnjJzyK6oIDEb7PcIwrp6bbYNsxQBN2+bxWXBRVzaSqqTHW2m9ZIjueXh PMiAJuFikvQuVP9YZZCubouCENj7pGeocxAoesUM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.101] ([213.142.97.158]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MAwbz-1n98Hb2x1F-00BMRM; Thu, 30 Dec 2021 09:34:42 +0100 In-Reply-To: <83ilv7jqm7.fsf@gnu.org> Content-Language: en-US X-Provags-ID: V03:K1:DjeDjZcAhKYIaOMAXPeHHDoZDeCozaLOWu8251INMPvvQhTHGVY 7Vr5KSDvGpDXrs+HC+wBWyvuBx2+pJU/paFEn0qwiiZEENeDIBn5mFH+9hISq+45ka9El6v KBV0Eqy7iAycMJ4+dq5TzyxozcJTUahZDi+7shMqHAd+VGGB54Wt0QhaPBQ9JaefjZFqPjP wuhGZsrYUihtRNlWr+gBw== X-UI-Out-Filterresults: notjunk:1;V03:K0:qVdfnPGMlx0=:DRQTwH7QIwjzeQ9j6ikTbK YKhbDLJNKLi4kgpK15gAJPd4RWn+dzMgqlCmzoDFQa74pfk0kDXHtNFzLP0K8328HTWOjM6li c5HxeRvdeuxiQ2M7DEwm+qBqa0KfWTIXE2BwUci03Gpw10XtdGwwoH0ZVPyOnPBqqpl9uHvaJ thzMlCZw32EVz3OhscjYx/h8SywuzqamuFxAVCVWAE9rQs0h27GrT4AY9iAZwDul24cejoo6A VuucmhQI81azR4zv/myg90Kr9Ug/AJhRAY3oYoDNxpDEga3cHWpGe2VX8fM3uBE9sIWz9MgJx SlIwJU/eFv6GL737noj449t3xT/61AAY05HOcAXg1IfnpcCneEZyfu1KJGfK3NC4Rh37Cy/iA fjVmW2qB1WUVCoGdTR9zbpSsE/TcigX3vwojnprdIvGwKUKs8+Z3s9nhL1+NE2g2g+Cx+ysOC duSWfecw1Fy/uTQ+SZPCsupmS0OSOVYiBQjYngdvTOIu1Z5YsDlwTVG86TTpx9f7pwuq+KrC1 yHCThlymUAJFI3pd9lep/KsXzz4qdxBHfqvKzwsrR4UQpn5GQtEAE75fXamEvekpew3/HlSe8 kPpzGcC8yiBbinsgAm8V7A34+GSL1LtvqURctYAUzTOA4kwaJDQkFmSqucxoouXuNCTLinv8/ vxAWj3PEjqio6e+SNH8aplRzTLbs9G5eOXJ+qpCcreuLpI6PrTIIRHuuRtg2uO+noVkM6jkxS +xZLOn+m7b4EW3v4s2WUdvm50ywLPimhFv2j5j7lU3ZFi6oYRWroEq7Jlleily19our3hnVX Received-SPF: pass client-ip=212.227.15.19; envelope-from=rudalics@gmx.at; helo=mout.gmx.net X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:283625 Archived-At: > Martin's opinions are more relevant, I think. Sorry, but I simply don't understand what's going on here. Sam Steingold's original report starts with the following statement: I would like to request reverting of the patch 70b64e0d040e9c57f1a489c9ebee553264033119 "Use pop-to-buffer-same-window for shell" When I already have a window with shell, this patch creates a second such window. It seems much more reasonable to use pop-to-buffer in eshell rather than break shell's behavior. If you insist on your desired behavior, please add a user variable `shell-pop-to-buffer-action` that you would set to `display-buffer--same-window-action`. Now IIUC the original code had 'pop-to-buffer' which conceptually does create a new window. 'pop-to-buffer-same-window' OTOH conceptually reuses the same window instead. So how that patch could provoke this behavior When I already have a window with shell, this patch creates a second such window. is beyond my understanding. Personally, I would not have installed the patch above because it changes long-standing default behavior. Users can always request displaying eshell in the same window via 'display-buffer-alist'. But the bug report itself yet remains a mystery to me. > Me, I think we have way too many display-buffer customization > machinery, so much so that we are confused ourselves what we have and > what we don't. But if others think this particular addition could be > useful, I don't mind: a defcustom doesn't by itself do any harm, > except perhaps making Emacs a tad more complex. If such a 'defcustom' does not affect a user's customizations via 'display-buffer-alist' I agree. But if a user is then forced to use that defcustom _instead of_ customizing 'display-buffer-alist', it would do harm IMHO. martin