From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>, Lars Ingebrigtsen <larsi@gnus.org>
Cc: sdsg@amazon.com, emacs-devel@gnu.org
Subject: Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action'
Date: Thu, 30 Dec 2021 09:34:41 +0100 [thread overview]
Message-ID: <6a9cd581-1630-4a95-62c4-419603561072@gmx.at> (raw)
In-Reply-To: <83ilv7jqm7.fsf@gnu.org>
> Martin's opinions are more relevant, I think.
Sorry, but I simply don't understand what's going on here. Sam
Steingold's original report starts with the following statement:
I would like to request reverting of the patch
70b64e0d040e9c57f1a489c9ebee553264033119 "Use pop-to-buffer-same-window for shell"
When I already have a window with shell, this patch creates a second
such window.
It seems much more reasonable to use pop-to-buffer in eshell rather than
break shell's behavior.
If you insist on your desired behavior, please add a user variable
`shell-pop-to-buffer-action` that you would set to
`display-buffer--same-window-action`.
Now IIUC the original code had 'pop-to-buffer' which conceptually does
create a new window. 'pop-to-buffer-same-window' OTOH conceptually
reuses the same window instead. So how that patch could provoke this
behavior
When I already have a window with shell, this patch creates a second
such window.
is beyond my understanding.
Personally, I would not have installed the patch above because it
changes long-standing default behavior. Users can always request
displaying eshell in the same window via 'display-buffer-alist'. But
the bug report itself yet remains a mystery to me.
> Me, I think we have way too many display-buffer customization
> machinery, so much so that we are confused ourselves what we have and
> what we don't. But if others think this particular addition could be
> useful, I don't mind: a defcustom doesn't by itself do any harm,
> except perhaps making Emacs a tad more complex.
If such a 'defcustom' does not affect a user's customizations via
'display-buffer-alist' I agree. But if a user is then forced to use
that defcustom _instead of_ customizing 'display-buffer-alist', it would
do harm IMHO.
martin
next prev parent reply other threads:[~2021-12-30 8:34 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <164073060906.21430.4993248796177370312@vcs2.savannah.gnu.org>
[not found] ` <20211228223009.6D0BAC002EE@vcs2.savannah.gnu.org>
2021-12-28 22:37 ` master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action' Dmitry Gutov
2021-12-28 22:59 ` jakanakaevangeli
2021-12-29 8:17 ` Juri Linkov
2021-12-29 15:00 ` Lars Ingebrigtsen
2021-12-29 16:57 ` Eli Zaretskii
2021-12-30 8:34 ` martin rudalics [this message]
2021-12-30 8:47 ` martin rudalics
2021-12-30 10:25 ` martin rudalics
2021-12-30 14:40 ` Stefan Monnier
2021-12-30 17:12 ` martin rudalics
2021-12-30 17:29 ` Lars Ingebrigtsen
2021-12-30 18:30 ` martin rudalics
2021-12-31 16:29 ` Lars Ingebrigtsen
2021-12-31 18:41 ` martin rudalics
2021-12-30 16:04 ` Juri Linkov
2021-12-30 17:14 ` martin rudalics
2021-12-31 16:47 ` Sam Steingold
2021-12-31 18:42 ` martin rudalics
2021-12-31 16:38 ` Sam Steingold
2021-12-31 18:42 ` martin rudalics
2021-12-31 18:55 ` Sam Steingold
2021-12-31 19:40 ` martin rudalics
2022-01-03 17:22 ` Sam Steingold
2021-12-30 17:24 ` Dmitry Gutov
2021-12-30 18:30 ` martin rudalics
2021-12-31 16:28 ` Lars Ingebrigtsen
2021-12-31 18:41 ` martin rudalics
2022-01-02 16:21 ` Madhu
2022-01-02 17:09 ` martin rudalics
2022-01-02 17:43 ` Juri Linkov
2022-01-02 18:40 ` martin rudalics
2022-01-02 20:52 ` Dmitry Gutov
2022-01-03 7:45 ` Juri Linkov
2022-01-03 18:21 ` martin rudalics
2022-01-03 18:38 ` Stefan Monnier
2022-01-04 10:25 ` martin rudalics
2022-01-04 15:48 ` Stefan Monnier
2022-01-03 21:07 ` Juri Linkov
2022-01-04 10:26 ` martin rudalics
2022-01-06 15:30 ` martin rudalics
2022-01-06 19:52 ` Juri Linkov
2022-01-07 10:36 ` martin rudalics
2022-01-07 18:49 ` Sam Steingold
2022-01-07 19:03 ` Eli Zaretskii
2022-01-07 19:16 ` Sam Steingold
2022-01-11 17:20 ` Juri Linkov
2022-01-11 18:02 ` martin rudalics
2022-01-11 18:15 ` Juri Linkov
2022-01-12 8:43 ` martin rudalics
2022-01-03 7:51 ` Juri Linkov
2021-12-29 17:29 ` Sam Steingold
2021-12-29 16:43 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a9cd581-1630-4a95-62c4-419603561072@gmx.at \
--to=rudalics@gmx.at \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=sdsg@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).