From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: emacs master + org Wrong type argument: number-or-marker-p Date: Mon, 1 Aug 2022 19:36:56 +0200 Message-ID: <6F871C02-AC26-4B89-B64B-E9F4ACACDBE7@acm.org> References: <83bkt42ifq.fsf@gnu.org> <87a68ovw0b.fsf@posteo.net> <835yjc2c6f.fsf@gnu.org> <8335eg2ao9.fsf@gnu.org> <875yjbexde.fsf@posteo.net> <83zggn2a0c.fsf@gnu.org> <03AF0800-5252-429C-86BC-85DF9DF449F9@acm.org> <83tu6v27yh.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33918"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, gregory@heytings.org, silent2600@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 01 19:55:06 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oIZdA-0008YK-Uv for ged-emacs-devel@m.gmane-mx.org; Mon, 01 Aug 2022 19:55:05 +0200 Original-Received: from localhost ([::1]:55962 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oIZd9-00045E-VG for ged-emacs-devel@m.gmane-mx.org; Mon, 01 Aug 2022 13:55:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34768) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIZLw-0001oc-Mn for emacs-devel@gnu.org; Mon, 01 Aug 2022 13:37:26 -0400 Original-Received: from mail1437c50.megamailservers.eu ([91.136.14.37]:47198 helo=mail263c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIZLm-0001Q8-Ju; Mon, 01 Aug 2022 13:37:08 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1659375419; bh=Jiz7KqMaa/BJBBCqzfPsQe3Yzu3pFLUcKDYgkS1lRrU=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=iV0/H82WxCth8rRc6Uj7NYME8vTkiwnF9E6V5EmDMsWHHXKEeijUlkSl+dQ5AATFY OrKUnPG3yppvxr7RUN9BC6v7VVMH2avH0eXx4/87P906asBNdcEVgC/9Lyb0JAkL6R mvTmEJxndw3m2PeGoMHr4Yri7AvYXAwmgnsVnTiY= Feedback-ID: mattiase@acm.or Original-Received: from smtpclient.apple (c188-150.188-179.bredband.tele2.se [188.150.188.179] (may be forged)) (authenticated bits=0) by mail263c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 271HauA4043660; Mon, 1 Aug 2022 17:36:59 +0000 In-Reply-To: <83tu6v27yh.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A782F17.62E80F3B.004C, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE Received-SPF: softfail client-ip=91.136.14.37; envelope-from=mattiase@acm.org; helo=mail263c50.megamailservers.eu X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292956 Archived-At: 1 aug. 2022 kl. 19.24 skrev Eli Zaretskii : > I don't know how to test it to verify the problem is fixed. I'm not sure I do either, because the change to narrow-to-region was = made without adding any tests at all. Frankly I'd recommend that the whole change be reverted because it = performs unbalanced specbinds which we expect functions not to do. I = don't think it can be salvaged in its current form; better back it out = and let the author submit a new proposal for how to handle the problem. Sorry about not noticing this earlier.