unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Steven Tamm <steventamm@mac.com>
Cc: emacs-devel@gnu.org
Subject: Re: Mac OS X - Hang / C-g problem patch
Date: Sat, 7 Dec 2002 22:15:21 -0800	[thread overview]
Message-ID: <6E796744-0A74-11D7-B27B-00039390AB82@mac.com> (raw)
In-Reply-To: <m265u955cs.fsf@owlbear.local>

Hi Andrew (and others interested in this problem),

I've checked in your patch with a few modification.
First, I added code to check for C-g instead of C-. to macterm.c.  
Right now it will only work if the quit_char is C-g, but I plan on 
adding code that will convert from ascii -> keycode later.  Anywhere 
this check should be done, call mac_check_for_quit_char().
Second, I made sys_read depend on sys_select to do the blocking.  I 
also made sys_select handle NULL as the timeout (so that sys_read could 
block forever)
Third, I didn't use signals, but instead sent the quit_char as an 
input_event to kbd_buffer_store_event.  This seemed like a better idea 
than directly using signals because things like last_event_timestamp 
are updated.
I left the call to mac_check_for_quit_char in Feval with a note in the 
cvs log that it might be removed.

I tried to run some profiling tests but none of the data I got seemed 
useful.  It seems to not be that expensive a call.  In any case I filed 
a couple radar bugs to see if the WindowManager could be programmed to 
send a signal based on a hotkey.  It's bug 3121160  (Allow ability to 
have a keypress cause a signal in Carbon).  I also reported a bug to be 
able to set the main event queue for an application to be a secondary 
thread, but doubt that it will go anywhere due to thread safety issues.

-Steven

  parent reply	other threads:[~2002-12-08  6:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-04 18:06 Mac OS X - Hang / C-g problem patch Steven Tamm
2002-12-05  6:48 ` Andrew Choi
2002-12-05 16:32   ` Steven Tamm
2002-12-05 23:47     ` Andrew Choi
2002-12-06 18:15       ` Steven Tamm
2002-12-08  6:15   ` Steven Tamm [this message]
2002-12-08 20:51     ` Andrew Choi
2002-12-09 10:13     ` dme
2002-12-09 16:42       ` Andrew Choi
2002-12-09 18:09       ` Steven Tamm
2002-12-10 12:38         ` dme

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6E796744-0A74-11D7-B27B-00039390AB82@mac.com \
    --to=steventamm@mac.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).