From: Yuan Fu <casouri@gmail.com>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: master e494ca4f4d 6/7: Fix treesit_record_change in casify_region
Date: Tue, 22 Nov 2022 11:16:29 -0800 [thread overview]
Message-ID: <6D71E065-4F80-4871-891D-BE34F6E4002C@gmail.com> (raw)
In-Reply-To: <87fseb49iw.fsf@yahoo.com>
> On Nov 22, 2022, at 1:35 AM, Po Lu <luangruo@yahoo.com> wrote:
>
> Yuan Fu <casouri@gmail.com> writes:
>
>> #ifdef HAVE_TREE_SITTER
>> - treesit_record_change (start_byte, old_end_byte, CHAR_TO_BYTE (end));
>> + treesit_record_change (start_byte, old_end_byte, CHAR_TO_BYTE (orig_end + added));
>> #endif
>> - }
>>
>> return orig_end + added;
>> }
>
> This is 88 columns! Would you please fill it to 80?
Sure, but now I’m confused. IIRC some style changes made to treesit.c unwraps some lines into long lines, which is why I didn’t wrap this line. What exactly is our policy?
Yuan
next prev parent reply other threads:[~2022-11-22 19:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166910803045.16429.10643976346308966505@vcs2.savannah.gnu.org>
[not found] ` <20221122090711.6DCF5C0E4BB@vcs2.savannah.gnu.org>
2022-11-22 9:35 ` master e494ca4f4d 6/7: Fix treesit_record_change in casify_region Po Lu
2022-11-22 19:16 ` Yuan Fu [this message]
2022-11-23 0:41 ` Po Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6D71E065-4F80-4871-891D-BE34F6E4002C@gmail.com \
--to=casouri@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).