From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sergey Kostyaev Newsgroups: gmane.emacs.devel Subject: Re: Add elisa to GNU ELPA Date: Thu, 18 Jul 2024 18:06:28 +0700 Message-ID: <6BADD5F8-F7E5-455E-93FA-78BFBF350885@gmail.com> References: <8734o9sdig.fsf@posteo.net> <2BA1B431-B60C-471D-9862-540DE7BB24C9@gmail.com> <87v813fz1f.fsf@posteo.net> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\)) Content-Type: multipart/alternative; boundary="Apple-Mail=_22BB13E6-113F-463C-9D01-8BA456021CB1" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3426"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 18 14:37:34 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sUQO6-0000gJ-JA for ged-emacs-devel@m.gmane-mx.org; Thu, 18 Jul 2024 14:37:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sUQNP-0002Kg-RE; Thu, 18 Jul 2024 08:36:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sUOyC-0007Sx-Pb for emacs-devel@gnu.org; Thu, 18 Jul 2024 07:06:44 -0400 Original-Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sUOyB-0006ci-4w for emacs-devel@gnu.org; Thu, 18 Jul 2024 07:06:44 -0400 Original-Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-52ea7d2a039so196849e87.3 for ; Thu, 18 Jul 2024 04:06:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721300801; x=1721905601; darn=gnu.org; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=eUf5IXwGso9pLyPfp4jQk+HePutfuub4K29LLCAHIdU=; b=Nh0uTjTfklDn00B5ac2A1NWVvnnzKkfO8/2EYdrzQFJW4gj8meeYlj3/RTN4Fo2oei 4WpU7OwJyOyNa2TinPzs7Xo5XPEG0GRv7MJckfjbwASmAuK87GhgUUR8EYPiOQarTj7K 8Px0IacVjKuil6yKTIapAXa5zeeDsSEO5jklUzlec3db2M+1FwujfR2OYzG+YEXTXmar 7gAP1AmikqJD7mkh2uZdvZk8So+fdX4SD1WrGotkq8WgzlVzfwSA9xYz0r+lk3ZIwEF4 Mg46oosnEXqHj4h4AIeUCO8/yjIdPjtrTnGxDDq3OAonZkd9D09XUU5G2eEsdUIieUHD Wriw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721300801; x=1721905601; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eUf5IXwGso9pLyPfp4jQk+HePutfuub4K29LLCAHIdU=; b=mm8VzYwvFb7W5Xf3ZPPXM6EeFaiD+eH+zYxRsFoA4axSktcU4NwT+Nb6C9z6gBnmMF gzYyEaReuYD+JXgbFVf2nhzKIkr7rKm+KphCblmpcZeHZ+goGUUN5fqwlSQ0BDuOjfzc Uv2BDtqvjnbRG4GSesh9Xr1hChMJuRKk0nBeFlmTpAUoGyiLclR3k9S037Gf4ELpiFgz QvlRObnTlESWuDATzWzH3oHjw3Ns7dIrcA0QIUOTSWDP0meQ8yTvbeln/20sTHpNPMPg m6T7MC5aNITgLzbOF8l2eHryB3sRfy6/eROYFsUM3mw/nj+fNdIWRrAp2iUe9DbbDs5v zLlw== X-Gm-Message-State: AOJu0YzEHLm58aZBN1Iuiwj7S1wtbomliS2gaJfFUiQkWPjNy2X69wxb HFqI1npHSDz1/2xemv6tgk3dcfmCMloicMQHhAhpyg6MxsrE9ZA+ X-Google-Smtp-Source: AGHT+IGU6ru0IIJ9otf8a2gKUC3FypnF4xnOKmAA6bdRWYu2bkVdjQssxb1k/BSKf68X6uHcKOW2dA== X-Received: by 2002:a05:6512:1243:b0:52e:9e70:d06e with SMTP id 2adb3069b0e04-52ee5441a67mr3044534e87.53.1721300800498; Thu, 18 Jul 2024 04:06:40 -0700 (PDT) Original-Received: from smtpclient.apple ([90.189.160.165]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52ef0776181sm54914e87.215.2024.07.18.04.06.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Jul 2024 04:06:40 -0700 (PDT) In-Reply-To: <87v813fz1f.fsf@posteo.net> X-Mailer: Apple Mail (2.3774.600.62) Received-SPF: pass client-ip=2a00:1450:4864:20::136; envelope-from=sskostyaev@gmail.com; helo=mail-lf1-x136.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 18 Jul 2024 08:36:50 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321790 Archived-At: --Apple-Mail=_22BB13E6-113F-463C-9D01-8BA456021CB1 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 All sql strings upcased. > 18 =D0=B8=D1=8E=D0=BB=D1=8F 2024=E2=80=AF=D0=B3., =D0=B2 05:12, Philip = Kaludercic =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB= (=D0=B0): >=20 > Sergey Kostyaev writes: >=20 >> I have fixed review issues and improve package documentation. Philip, = please see one more time. >=20 > I admit I was lazy; there are a few SQL strings that could still > upcased. >=20 > A general question I have is why you depend on Emacs 29.2? = Package-lint > indicates that you don't need anything before 28.1, with the exception > of the SQLite integration, which would mean you could reduce the = minimal > version to 29.1. >=20 > Otherwise I guess it looks fine, I'll add it to elpa.git. >=20 >> Best regards, >> Sergey Kostyaev >>=20 >=20 > --=20 > Philip Kaludercic on peregrine Best regards, Sergey Kostyaev --Apple-Mail=_22BB13E6-113F-463C-9D01-8BA456021CB1 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 All sql = strings upcased.

18 =D0=B8=D1=8E=D0=BB=D1=8F 2024=E2=80=AF=D0=B3., =D0=B2= 05:12, Philip Kaludercic <philipk@posteo.net> = =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0):

Sergey Kostyaev = <sskostyaev@gmail.com> writes:

I = have fixed review issues and improve package documentation. Philip, = please see one more time.

I admit I was lazy; there = are a few SQL strings that could still
upcased.

A general = question I have is why you depend on Emacs 29.2? =  Package-lint
indicates that you don't need anything before = 28.1, with the exception
of the SQLite integration, which would mean = you could reduce the minimal
version to 29.1.

Otherwise I = guess it looks fine, I'll add it to elpa.git.

Best regards,
Sergey = Kostyaev


--
Philip Kaludercic on = peregrine

Best regards,
Sergey Kostyaev

= --Apple-Mail=_22BB13E6-113F-463C-9D01-8BA456021CB1--