From: "Jan Djärv" <jan.h.d@swipnet.se>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Blink cursor changes, possible W32 breakage.
Date: Tue, 16 Jul 2013 23:12:49 +0200 [thread overview]
Message-ID: <6B4F86F0-164D-4CBE-8CD2-9BC9326451C4@swipnet.se> (raw)
In-Reply-To: <83oba22ymd.fsf@gnu.org>
Hello.
16 jul 2013 kl. 19:39 skrev Eli Zaretskii <eliz@gnu.org>:
>> From: Jan Djärv <jan.h.d@swipnet.se>
>> Date: Tue, 16 Jul 2013 13:48:49 +0200
>>
>> Just a heads up, I changed blink cursor in two ways, one is that it stops blinking after blinking
>> blink-cursor-blinks number of times (10 by default), as inspired by gnome-terminal. Also, timers are stopped when no blinking occurs.
>
> Why do we want that? Is there a way to get previous behavior?
To stop blink timers when there are no blinking cursors. Put the variable to 0 to get previous behaviour, i.e. never stop blinking.
>
>> This works on NS and X but not on W32. I tried to be careful to not break W32, but it might happen anyway. If anybody wants to implement this for W32, you basically need to implement generating a FOCUS_OUT_EVENT, like xterm,c and nsterm.m does and adjust those places in keyboard.c and frame.el that checks for X and NS only.
>
> Sorry, I don't understand: w32 already implements the equivalent of
> FOCUS_OUT_EVENT, but why is that relevant? When no frame has focus,
> Emacs on Windows doesn't blink the cursors already.
Yes, but timers are still running, so Emacs are never swapped out, and drains battery on laptops (yes it makes a difference). The FOCUS_OUT_EVENT turns timers off, and FOCUS_IN_EVENT turns them back on, if needed. This was discussed a long time ago, starting here:
http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00640.html.
> What am I missing?
>
> And what is the other thing you changed?
1) Blinking stops after 10 blinks.
2) Timers are stopped when no blinking is done.
Jan D.
next prev parent reply other threads:[~2013-07-16 21:12 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 11:48 Blink cursor changes, possible W32 breakage Jan Djärv
2013-07-16 15:55 ` Glenn Morris
2013-07-16 16:15 ` Jan Djärv
2013-07-16 18:29 ` covici
2013-07-16 18:49 ` Eli Zaretskii
2013-07-16 20:19 ` covici
2013-07-16 17:00 ` Juanma Barranquero
2013-07-16 17:39 ` Eli Zaretskii
2013-07-16 18:02 ` Lars Magne Ingebrigtsen
2013-07-16 18:30 ` Eli Zaretskii
2013-07-16 22:05 ` Stefan Monnier
2013-07-16 21:12 ` Jan Djärv [this message]
2013-07-16 21:23 ` Lars Magne Ingebrigtsen
2013-07-16 22:04 ` Óscar Fuentes
2013-07-17 1:58 ` Miles Bader
2013-07-17 7:42 ` Jan Djärv
2013-07-17 14:58 ` Eli Zaretskii
2013-07-17 15:02 ` Lars Magne Ingebrigtsen
2013-07-17 8:38 ` Stefan Monnier
2013-07-17 4:04 ` Eli Zaretskii
2013-07-17 4:56 ` Miles Bader
2013-07-17 7:38 ` Jan Djärv
2013-07-17 14:56 ` Eli Zaretskii
2013-07-17 16:29 ` Jan Djärv
2013-07-17 17:05 ` Eli Zaretskii
2013-07-17 18:53 ` Jan Djärv
2013-07-17 19:23 ` Eli Zaretskii
2013-07-17 19:38 ` Jan Djärv
2013-07-19 2:12 ` Miles Bader
2013-07-19 6:39 ` Eli Zaretskii
2013-07-19 9:33 ` Stefan Monnier
2013-07-19 10:07 ` Eli Zaretskii
2013-07-19 10:50 ` Óscar Fuentes
2013-07-19 11:13 ` Eli Zaretskii
2013-07-19 12:02 ` Óscar Fuentes
2013-07-19 13:43 ` Eli Zaretskii
2013-07-19 17:52 ` Thien-Thi Nguyen
2013-07-20 8:18 ` Stefan Monnier
2013-07-20 9:25 ` Eli Zaretskii
2013-07-20 22:42 ` Stefan Monnier
2013-07-21 2:45 ` Eli Zaretskii
2013-07-21 7:46 ` Stefan Monnier
2013-07-21 15:43 ` Eli Zaretskii
2013-07-22 2:47 ` Stefan Monnier
2013-07-19 10:54 ` Lars Magne Ingebrigtsen
2013-07-19 9:32 ` Stefan Monnier
2013-07-19 10:08 ` Eli Zaretskii
2013-07-20 8:16 ` Stefan Monnier
2013-07-20 9:26 ` Eli Zaretskii
2013-07-20 22:40 ` Stefan Monnier
2013-07-21 2:44 ` Eli Zaretskii
2013-07-21 7:45 ` Stefan Monnier
2013-07-21 15:42 ` Eli Zaretskii
2013-07-22 2:46 ` Stefan Monnier
2013-07-21 9:20 ` martin rudalics
2013-07-22 2:55 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6B4F86F0-164D-4CBE-8CD2-9BC9326451C4@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).