Bootstrap fails on Mac OS X

Bootstrap fails on Mac OS X

[Enrico Franconi]

Hi.
With latest CVS, make bootstrap fails on Mac OS X 10.3.6 gcc 3.3.
Can you help me?
cheers
--e.

 > make maintainer-clean
./configure --enable-carbon-app=/Applications --without-x
 > make bootstrap
(...)
gcc -I/sw/include -L/sw/lib -c -fpascal-strings -fno-common -DMAC_OSX 
-I../mac/src   -Demacs -DHAVE_CONFIG_H   -I. 
-I/Applications/-Programs/-Software/ec-emacs/cvs-emacs/emacs/src 
-fpascal-strings -fno-common -DMAC_OSX -I../mac/src -Dtemacs -g -O2 
editfns.c
In file included from editfns.c:43:
/usr/include/sys/resource.h:81: error: field `ru_utime' has incomplete 
type
/usr/include/sys/resource.h:82: error: field `ru_stime' has incomplete 
type
make[1]: *** [editfns.o] Error 1
make: *** [bootstrap] Error 2

Re: Bootstrap fails on Mac OS X

[YAMAMOTO Mitsuharu]

>>>>> On Sun, 7 Nov 2004 06:22:19 +0100, Enrico Franconi <franconi@inf.unibz.it> said:

> Hi.  With latest CVS, make bootstrap fails on Mac OS X 10.3.6 gcc
> 3.3.  Can you help me?

On Mac OS X, getrusage requires to include sys/time.h as well as
sys/resource.h.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

Index: src/editfns.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/editfns.c,v
retrieving revision 1.383
diff -c -r1.383 editfns.c
*** src/editfns.c	6 Nov 2004 17:00:37 -0000	1.383
--- src/editfns.c	7 Nov 2004 05:41:27 -0000
***************
*** 39,44 ****
--- 39,48 ----
  #include <stdio.h>
  #endif
  
+ #ifdef HAVE_SYS_TIME_H
+ #include <sys/time.h>
+ #endif
+ 
  #if defined HAVE_SYS_RESOURCE_H
  #include <sys/resource.h>
  #endif

Re: Bootstrap fails on Mac OS X

[Steven Tamm]

Fixed.

I first checked something else in, but this was better.  I didn't do 
this first because of the later include of "systime.h" but it should be 
declared ahead of time in any case.  Perhaps resource.h should be 
included after "systime.h"?

-Steven

On Nov 6, 2004, at 9:44 PM, YAMAMOTO Mitsuharu wrote:

> #ifdef HAVE_SYS_TIME_H
> + #include <sys/time.h>
> + #endif

Re: Bootstrap fails on Mac OS X

[Enrico Franconi]

> On Mac OS X, getrusage requires to include sys/time.h as well as 
> sys/resource.h.

Thanks, fixed.
--e.

Re: Bootstrap fails on Mac OS X

[YAMAMOTO Mitsuharu]

>>>>> On Sat, 6 Nov 2004 21:56:31 -0800, Steven Tamm <steventamm@mac.com> said:

> I first checked something else in, but this was better.  I didn't do
> this first because of the later include of "systime.h" but it should
> be declared ahead of time in any case.  Perhaps resource.h should be
> included after "systime.h"?

Actually, I just added #include without such a consideration, and I
can't say which is better.  So I'd like to leave it to experts.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

Re: Bootstrap fails on Mac OS X

[Eli Zaretskii]

> Date: Sun, 07 Nov 2004 15:24:54 +0900
> From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
> Cc: Enrico Franconi <franconi@inf.unibz.it>, emacs-devel@gnu.org
> 
> >>>>> On Sat, 6 Nov 2004 21:56:31 -0800, Steven Tamm <steventamm@mac.com> said:
> 
> > I first checked something else in, but this was better.  I didn't do
> > this first because of the later include of "systime.h" but it should
> > be declared ahead of time in any case.  Perhaps resource.h should be
> > included after "systime.h"?
> 
> Actually, I just added #include without such a consideration, and I
> can't say which is better.  So I'd like to leave it to experts.

I fixed this in a little more general mannaer; please see if the
current CVS compiles and works on Mac OS X.

Thanks.

Re: Bootstrap fails on Mac OS X

[Jan D.]

>
> I fixed this in a little more general mannaer; please see if the
> current CVS compiles and works on Mac OS X.

It does.

	Jan D.