unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Jan D." <jan.h.d@swipnet.se>
Cc: Giuseppe Scrivano <gscrivano@gmail.com>,
	rms@gnu.org, emacs-devel@gnu.org
Subject: Re: emacs & MAXPATHLEN
Date: Sat, 30 Jul 2005 13:27:23 +0200	[thread overview]
Message-ID: <6A777234-348C-42E3-9FE1-7519B533F134@swipnet.se> (raw)
In-Reply-To: <uy87o4l5q.fsf@gnu.org>

>
>> +#else
>> +      {
>> +        int buf_size = 2;
>> +        buf = xmalloc (buf_size);
>> +        for(;;)
>> +          {
>> +            if(getcwd (buf, buf_size) == 0)
>> +              {
>> +                if(errno == ERANGE)
>> +                  {
>> +                    buf_size *= 2;
>> +                    buf = xrealloc (buf, buf_size);
>> +                  }
>> +                else
>> +                  fatal ("`getcwd' failed: %s\n", strerror (errno));
>> +              }
>> +            else
>> +              break;
>> +          }
>> +
>> +      }
>> +#endif
>>

You can initialize buf_size to something bigger than 2.  This almost  
guarantees multiple calls to realloc.  Try 1024 or something more  
reasonable that will at least hold most paths.  2 will only hold "/"  
and nothing else.

Also, space after if and for.

     Jan D.

  reply	other threads:[~2005-07-30 11:27 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-28 15:32 emacs & MAXPATHLEN Giuseppe Scrivano
2005-07-29  0:11 ` Richard M. Stallman
2005-07-29  0:22   ` Giuseppe Scrivano
2005-07-29 13:29     ` Alfred M. Szmidt
2005-07-29 13:54     ` Richard M. Stallman
2005-07-29 18:30       ` Giuseppe Scrivano
2005-07-30  1:31       ` Giuseppe Scrivano
2005-07-30 10:56         ` Eli Zaretskii
2005-07-30 11:27           ` Jan D. [this message]
2005-07-30 11:53           ` Alfred M. Szmidt
2005-07-30 14:28             ` Eli Zaretskii
2005-07-30 14:46               ` Alfred M. Szmidt
2005-07-30 17:35               ` Andreas Schwab
2005-07-30 18:06                 ` Eli Zaretskii
2005-07-30 18:18                   ` Jan D.
2005-07-30 19:11                   ` Andreas Schwab
2005-08-01  0:46                 ` Richard M. Stallman
2005-08-01  8:58                   ` Andreas Schwab
2005-08-01 16:46                     ` Richard M. Stallman
2005-08-01 18:03                       ` David Kastrup
2005-08-03 13:33                         ` Richard M. Stallman
2005-08-03 14:09                           ` David Kastrup
2005-08-03 23:11                             ` Richard M. Stallman
2005-08-04  6:30                               ` David Kastrup
2005-08-04 10:44                                 ` Sascha Wilde
2005-08-04 11:13                                   ` David Kastrup
2005-08-04 14:25                                     ` Sascha Wilde
2005-08-04 14:38                                       ` David Kastrup
2005-08-04 17:57                                         ` Alfred M. Szmidt
2005-08-04 18:11                                         ` Juanma Barranquero
2005-08-04 18:41                                           ` David Kastrup
2005-08-04 18:46                                             ` Juanma Barranquero
2005-08-04 19:07                                         ` Markus Gritsch
2005-08-01 18:52                       ` Andreas Schwab
2005-08-02 17:44                         ` Richard M. Stallman
2005-07-30 23:44             ` Richard M. Stallman
2005-07-31  0:05               ` Giuseppe Scrivano
2005-07-30 11:49         ` Alfred M. Szmidt
2005-07-30 12:23           ` Jan D.
2005-07-30 12:50             ` Alfred M. Szmidt
2005-07-30 12:58               ` Giuseppe Scrivano
2005-07-30 13:11               ` Andreas Schwab
2005-07-30 13:38                 ` Giuseppe Scrivano
2005-07-30 12:52           ` Giuseppe Scrivano
2005-07-30 15:17         ` Richard M. Stallman
2005-07-30 17:18           ` Giuseppe Scrivano
2005-08-01  0:46             ` Richard M. Stallman
2005-08-01 13:38               ` Giuseppe Scrivano
2005-07-29 13:54     ` Eli Zaretskii
2005-07-30  3:34       ` Richard M. Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6A777234-348C-42E3-9FE1-7519B533F134@swipnet.se \
    --to=jan.h.d@swipnet.se \
    --cc=emacs-devel@gnu.org \
    --cc=gscrivano@gmail.com \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).