From: "Mattias Engdegård" <mattiase@acm.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: master 68ae6fa: Improved light/dark colour predicate (bug#41544)
Date: Wed, 10 Jun 2020 21:34:31 +0200 [thread overview]
Message-ID: <6A0771E4-917D-4196-BF2A-3958864AD2A7@acm.org> (raw)
In-Reply-To: <jwvtuzienns.fsf-monnier+emacs@gnu.org>
10 juni 2020 kl. 21.20 skrev Stefan Monnier <monnier@iro.umontreal.ca>:
> Could we arrange to share the code with `color-srgb-to-xyz` (in `color.el`)?
We could, but I thought it useful to have the freedom to tweak the coefficients (and the gamma conversion) as required for this specific purpose, rather than being stuck with the theoretical CIE luminance from sRGB. This gives us more degrees of freedom than just having the cut-off value as modifiable parameter.
Experiments with some alternative coefficients and exponents showed fairly good results, but I went with the safer set of numbers for the initial version.
> Where does this 0.6 come from?
It's documented above, "a cut-off value determined experimentally". I can move the comment closer to the number.
next prev parent reply other threads:[~2020-06-10 19:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200610181238.9796.44750@vcs0.savannah.gnu.org>
[not found] ` <20200610181239.947C4204DF@vcs0.savannah.gnu.org>
2020-06-10 19:20 ` master 68ae6fa: Improved light/dark colour predicate (bug#41544) Stefan Monnier
2020-06-10 19:34 ` Mattias Engdegård [this message]
2020-06-10 20:01 ` Stefan Monnier
2020-06-11 5:15 ` Yuri Khan
2020-06-11 16:15 ` Mattias Engdegård
2020-06-11 19:22 ` Yuri Khan
2020-06-12 15:50 ` Mattias Engdegård
2020-06-12 16:22 ` tomas
2020-06-12 18:36 ` Yuri Khan
2020-06-13 10:55 ` Mattias Engdegård
2020-06-12 19:02 ` Drew Adams
2020-06-12 19:09 ` Stephen Leake
2020-06-18 19:28 ` Mattias Engdegård
2020-06-18 19:35 ` Drew Adams
2020-06-18 20:04 ` Mattias Engdegård
2020-06-18 20:32 ` Drew Adams
2020-06-21 7:51 ` Mattias Engdegård
2020-06-18 19:40 ` Basil L. Contovounesios
2020-06-18 19:58 ` Mattias Engdegård
2020-06-13 4:05 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0771E4-917D-4196-BF2A-3958864AD2A7@acm.org \
--to=mattiase@acm.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).