From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: delete-selection-mode as default Date: Sun, 9 Sep 2018 07:22:13 -0700 (PDT) Message-ID: <696a045c-ef14-4eb3-b951-eb13a9e112f4@default> References: <83k1nxvm5j.fsf@gnu.org> <877ejxsm18.fsf@toy.adminart.net> <87r2i5308w.fsf@gmail.com> <8336ulv2le.fsf@gnu.org> <87tvmz62q1.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1536502829 22485 195.159.176.226 (9 Sep 2018 14:20:29 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 9 Sep 2018 14:20:29 +0000 (UTC) Cc: emacs-devel@gnu.org To: Juri Linkov , Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 09 16:20:25 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fz0Zd-0005lG-46 for ged-emacs-devel@m.gmane.org; Sun, 09 Sep 2018 16:20:25 +0200 Original-Received: from localhost ([::1]:47582 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fz0bj-0001ly-9o for ged-emacs-devel@m.gmane.org; Sun, 09 Sep 2018 10:22:35 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fz0ba-0001cj-Ad for emacs-devel@gnu.org; Sun, 09 Sep 2018 10:22:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fz0bW-00018g-Tq for emacs-devel@gnu.org; Sun, 09 Sep 2018 10:22:26 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:36638) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fz0bT-00013z-1L for emacs-devel@gnu.org; Sun, 09 Sep 2018 10:22:19 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w89EEiUM122051; Sun, 9 Sep 2018 14:22:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=nfWuSbfYxUewQT6pcsuZaQNtWYAzwXi3rydV7zh6Iek=; b=Rq1KtmLI88qv/ZwnQULoN/LV3lTyRwW+Ua0Y+pJq0bpJGznn4Hjsn6t43cA7c8aC7J7R SmfWywEezf1yIs8z8vp+qU8tyhBGcERb+1oVhdpHqgSUXmFmbbK1e4ory/44O5XM7a+e fWBIHir8heEojljKuWUqP3M29lAUYvp0TZEsRpALeFrXz9Cp5l2Ip2Tb0vOMbdxLZS6n /HoHCQag4ALtXJdkrYgvUnGTeubkqUzU3ZCqHHKa6lCXDG6r83L0TUg7Y159KxQ7aWiV Plr4pGTEEJUElTvAiXiuc7HkrOjJMlY3iDjnwkC14US7rqqLiWSf9Ka219jjR6zwA3tm Eg== Original-Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2120.oracle.com with ESMTP id 2mc72qaenr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 09 Sep 2018 14:22:16 +0000 Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w89EMF8r022905 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 9 Sep 2018 14:22:15 GMT Original-Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w89EME0l032664; Sun, 9 Sep 2018 14:22:15 GMT In-Reply-To: <87tvmz62q1.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4735.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9010 signatures=668708 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=953 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1809090157 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 156.151.31.85 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:229555 Archived-At: > > FWIW, while I personally don't use delete-selection-mode, I wouldn't > > object to enabling it by default (I'd probably disable it in my .emacs, > > but I'd first try to keep it enabled to see if I can change my habits). > > > > But before that I'd appreciate if we could improve its implementation s= o > > it doesn't rely on pre-command-hook. >=20 > Incidentally, yesterday I discovered a case when Wdired breaks > delete-selection-mode. Selecting a file name in Wdired and starting > to type its new name to completely replace an old name with a new one > signals the error "No file on this line", then removes > delete-selection-pre-hook from pre-command-hook while leaving > delete-selection-mode still active, so delete-selection-mode becomes > completely broken - it doesn't replace the selection anymore. >=20 > I had to disable and then enable delete-selection-mode again > to get delete-selection-pre-hook back to pre-command-hook. >=20 > The error that removes delete-selection-pre-hook from pre-command-hook > logged in *Messages* is: >=20 > Error in pre-command-hook (delete-selection-pre-hook): (error "No file = on this > line") I don't see that at all. What recipe did you use, in what Emacs release? 1. emacs -Q 2. Turn on d-s-m 3. Dired in some buffer 4. C-x C-q ; enable Wdired 5. Select a complete file name 6. Type to replace that name with another name 7. C-x C-q ; disable Wdired At no point did Emacs raise an error. In GNU Emacs 26.1 (build 1, x86_64-w64-mingw32) of 2018-05-30 built on CIRROCUMULUS Repository revision: 07f8f9bc5a51f5aa94eb099f3e15fbe0c20ea1ea Windowing system distributor 'Microsoft Corp.', version 10.0.16299