From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: Scan of Emacs regexp mistakes Date: Thu, 16 Apr 2020 12:29:01 +0200 Message-ID: <6925612A-DC30-46B1-B91A-E7ADFA367C15@acm.org> References: <140DB045-4529-4862-99B8-5F0DEF1EE8D4@acm.org> <06c10772-75fa-0f80-2ed5-775e5b245b16@cs.ucla.edu> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="13926"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 16 12:41:31 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jP1xa-0003Xz-VA for ged-emacs-devel@m.gmane-mx.org; Thu, 16 Apr 2020 12:41:30 +0200 Original-Received: from localhost ([::1]:60530 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jP1xa-0002pm-1R for ged-emacs-devel@m.gmane-mx.org; Thu, 16 Apr 2020 06:41:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37500) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jP1wh-0001j8-U4 for emacs-devel@gnu.org; Thu, 16 Apr 2020 06:40:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jP1wg-0000aJ-Ke for emacs-devel@gnu.org; Thu, 16 Apr 2020 06:40:35 -0400 Original-Received: from mail1479c50.megamailservers.eu ([91.136.14.79]:47054 helo=mail118c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jP1wg-0000Z5-1Y for emacs-devel@gnu.org; Thu, 16 Apr 2020 06:40:34 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1587032944; bh=ZsC7YC/lntXUhcL/4NQRXa27DapWmk0X4qXk3rO1u1Q=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=E3Yk0SlrdtZeP6Dvrokm0+NXEmPFzE1utoD/p6A+D5wOF/WlTlshD9qz2Rlx1W3Wc 9gQzxXYmW/fZ4v3N4ygz9YY7BkTo3skeFvV7hXBYhGMFdWXzUlvviZySvPctiSw0zS nWyOhtBLNZ6b7tXk2puv9IkAMK5x+OnIj0f/g7kU= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail118c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 03GAT1AR007638; Thu, 16 Apr 2020 10:29:04 +0000 In-Reply-To: <06c10772-75fa-0f80-2ed5-775e5b245b16@cs.ucla.edu> X-Mailer: Apple Mail (2.3445.104.14) X-CTCH-RefID: str=0001.0A782F1A.5E983341.005B, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=KaGsTjQD c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=QqUf3L1uKVhF1KuvFeIA:9 a=CjuIK1q_8ugA:10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 91.136.14.79 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:247083 Archived-At: 15 apr. 2020 kl. 20.19 skrev Paul Eggert : > Should those trailing "$"s be changed to "\\'"s? Thanks, now fixed. (Those weren't caught by relint but by manual = inspection, hence the unfinished work.) > We shouldn't have two names for the same variable. I suggest = obsoleting dired-re-no-dot and replacing its only use with = directory-files-no-dot-files-regexp. Yes; the initial changes were deliberately limited in scope. > As Drew's comments make evident, the doc string is unclear. It should = be something like 'Regexp that matches part of a nonempty string if the = string is neither "." nor "..".' A clarification has been added, and a note about the intended use. > Shouldn't this and similar uses of (rx (or (not ".") "...")) be = replaced by directory-files-no-dot-files-regexp? That would be clearer. Very much so. All done on master. > I agree with you that directory-files should not return "." and "..", = though that indeed is a different topic. Seems to be a common syndrome in older runtimes (Emacs Lisp, Perl), = absent in newer ones (OCaml, Python).