From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Collin Funk Newsgroups: gmane.emacs.devel Subject: Re: master 86c4e5a2fb3: Fix implicit declaration of bswap_{32,64} Date: Sat, 30 Mar 2024 01:44:16 -0700 Message-ID: <68f9d9ed-5d13-42b0-9960-cc402b5c48f7@gmail.com> References: <86zfugcexr.fsf@gnu.org> <87le603ypo.fsf@linux-m68k.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11936"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Mar 30 09:45:22 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rqUL4-0002tm-Ba for ged-emacs-devel@m.gmane-mx.org; Sat, 30 Mar 2024 09:45:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rqUK7-0007eU-DU; Sat, 30 Mar 2024 04:44:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rqUK6-0007dr-5o for emacs-devel@gnu.org; Sat, 30 Mar 2024 04:44:22 -0400 Original-Received: from mail-il1-x132.google.com ([2607:f8b0:4864:20::132]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rqUK4-0005x9-Mi for emacs-devel@gnu.org; Sat, 30 Mar 2024 04:44:21 -0400 Original-Received: by mail-il1-x132.google.com with SMTP id e9e14a558f8ab-36894e0aaabso10619585ab.2 for ; Sat, 30 Mar 2024 01:44:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711788258; x=1712393058; darn=gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=W0d2EABhtd4XrpM7zFEytAAGhFFW7Ewyj9xpcGQD/t0=; b=SdGXTmaBHvVwPNWE3sbMr1gE0VPZEJFusQlrbBtDImC8BZercc5BSfxOHc40Lk8Z2g U1VFUhIQBxLsDgORNJDuH6LIpN5zQhY6oSrDd8wD8Vi9OfhlWXfthmdsmjlA12XF4EMN 0+3pitda3KiWHnxaCwgoXwd1RlQu9jhKfAKQFzrRws3+xzML88vH/uHwpV9B9Cl7gimu NovlFrVU5DRUVcJ4I1NAJzRw1o3ekJOL9MEUJd7cyX8usSvk7FpSNeUhRUZky8V5MOaN WMtlGk3DM8btq4Nyew5INK+s28VuQqb6rEGTCrvL4e7GibBrmJyNs8IScatwLoF7kQWU iXog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711788258; x=1712393058; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=W0d2EABhtd4XrpM7zFEytAAGhFFW7Ewyj9xpcGQD/t0=; b=bqZwYoSvozoT4LMxGV6EZUkHi0zg+lOLQySa6Jbwa3CEL1hELTzbiBWy4yT5szs9K5 0J28DhQ/qHihBCiuLBTZFZ8x1TsmNph/TyTUGkdxFknl2Sf3pP/DSKty3SFsEf9HkPvJ SruXBgmfkN84zhJOCCuqAIwQO4IWD+wK50+brlVSBapK0Q0iQH6/aWOWRAHVqtsrMSq0 fUS/ZHykcyOJT5Nyui8GbIMS/LlVdRrERmFSUuFczc+Vxtfh7k/Wi4r9fILq+0pvRfth TqXs1zZfBhiPdLxPD/0tj2bBc7OzP3oVYVjex7HAxMa4QkolNMDq8WtTmEGrLEybPsiU xRMg== X-Gm-Message-State: AOJu0YzP1YxBrPJ6anhKCUG+dR/vypHyGk/62Gh9fIdLtMPa6g3hALeX QGodgZgZZQ/rrHidudQ7kvUvbOkCJWpU8Ga/rm926IhTzKAxq+68CN5u7ah1sls= X-Google-Smtp-Source: AGHT+IELH0nffyhHhHnjL3Qmmj4SRJDjZGYcH6HWuqFFvQuzuvcrb1vJNnV7+2ki0OYe1BmkSRg3aw== X-Received: by 2002:a05:6e02:1a6f:b0:368:bf16:abae with SMTP id w15-20020a056e021a6f00b00368bf16abaemr3886478ilv.31.1711788258347; Sat, 30 Mar 2024 01:44:18 -0700 (PDT) Original-Received: from [192.168.1.5] (c-73-189-213-139.hsd1.ca.comcast.net. [73.189.213.139]) by smtp.gmail.com with ESMTPSA id v25-20020a631519000000b005d66caee3d0sm4096400pgl.22.2024.03.30.01.44.17 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 30 Mar 2024 01:44:17 -0700 (PDT) Content-Language: en-US In-Reply-To: <87le603ypo.fsf@linux-m68k.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::132; envelope-from=collin.funk1@gmail.com; helo=mail-il1-x132.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317388 Archived-At: On 3/30/24 1:34 AM, Andreas Schwab wrote: >> Wouldn't it be better to use __builtin_bswap32 when it's available? > The compiler is smart enough to do that by itself. The macro would evaluate it's arguments multiple times though right? This line: uint32_t result = bswap_32 (value++); should increment 'value' once, but would do it four times with a macro. Collin