From: Collin Funk <collin.funk1@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: master 86c4e5a2fb3: Fix implicit declaration of bswap_{32,64}
Date: Sat, 30 Mar 2024 01:44:16 -0700 [thread overview]
Message-ID: <68f9d9ed-5d13-42b0-9960-cc402b5c48f7@gmail.com> (raw)
In-Reply-To: <87le603ypo.fsf@linux-m68k.org>
On 3/30/24 1:34 AM, Andreas Schwab wrote:
>> Wouldn't it be better to use __builtin_bswap32 when it's available?
> The compiler is smart enough to do that by itself.
The macro would evaluate it's arguments multiple times though right?
This line:
uint32_t result = bswap_32 (value++);
should increment 'value' once, but would do it four times with a
macro.
Collin
next prev parent reply other threads:[~2024-03-30 8:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-30 8:16 master 86c4e5a2fb3: Fix implicit declaration of bswap_{32,64} Eli Zaretskii
2024-03-30 8:34 ` Andreas Schwab
2024-03-30 8:44 ` Collin Funk [this message]
2024-03-30 16:44 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68f9d9ed-5d13-42b0-9960-cc402b5c48f7@gmail.com \
--to=collin.funk1@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).