unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Speedup of functions to en/decode UTF-8 text
@ 2019-11-23  9:37 Eli Zaretskii
  2019-11-23 10:43 ` João Távora
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Eli Zaretskii @ 2019-11-23  9:37 UTC (permalink / raw)
  To: Ivan Yonchovski, João Távora; +Cc: emacs-devel

I've made some changes in the functions that encode and decode UTF-8
text in an optimized fashion.  This is expected to speed up JSON
handling.  Some preliminary benchmarking of the decoding function
indicates speed improvements starting at modest 30-40%, and sometimes
much higher -- tenfold or more.  I'm not sure how this will fare in
the real-life handling of JSON objects, so I'd welcome speed
measurements of the current master branch as compared to previous
versions (yesterday and older) in real-life scenarios, in particular
in LSP and Eglot.  Please report the results here, and if there are
some significantly adverse effects of these changes, please report
them as bugs.

TIA



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Speedup of functions to en/decode UTF-8 text
  2019-11-23  9:37 Speedup of functions to en/decode UTF-8 text Eli Zaretskii
@ 2019-11-23 10:43 ` João Távora
  2019-11-23 10:48   ` Eli Zaretskii
  2019-11-23 15:27 ` Stefan Monnier
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 7+ messages in thread
From: João Távora @ 2019-11-23 10:43 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: Ivan Yonchovski, emacs-devel

I work on multiple branches, and I don't always wish to rebase them
on top of master.  Can you say exactly what commit SHA's your
changes consists of, presuming I can cherry-pick them to those
branches?

Thanks,
João



On Sat, Nov 23, 2019 at 9:38 AM Eli Zaretskii <eliz@gnu.org> wrote:
>
> I've made some changes in the functions that encode and decode UTF-8
> text in an optimized fashion.  This is expected to speed up JSON
> handling.  Some preliminary benchmarking of the decoding function
> indicates speed improvements starting at modest 30-40%, and sometimes
> much higher -- tenfold or more.  I'm not sure how this will fare in
> the real-life handling of JSON objects, so I'd welcome speed
> measurements of the current master branch as compared to previous
> versions (yesterday and older) in real-life scenarios, in particular
> in LSP and Eglot.  Please report the results here, and if there are
> some significantly adverse effects of these changes, please report
> them as bugs.
>
> TIA



--
João Távora



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Speedup of functions to en/decode UTF-8 text
  2019-11-23 10:43 ` João Távora
@ 2019-11-23 10:48   ` Eli Zaretskii
  0 siblings, 0 replies; 7+ messages in thread
From: Eli Zaretskii @ 2019-11-23 10:48 UTC (permalink / raw)
  To: João Távora; +Cc: yyoncho, emacs-devel

> From: João Távora <joaotavora@gmail.com>
> Date: Sat, 23 Nov 2019 10:43:08 +0000
> Cc: Ivan Yonchovski <yyoncho@gmail.com>, emacs-devel <emacs-devel@gnu.org>
> 
> I work on multiple branches, and I don't always wish to rebase them
> on top of master.  Can you say exactly what commit SHA's your
> changes consists of, presuming I can cherry-pick them to those
> branches?

It's commit c26556b on master.  (It might look scary at first sight,
but most of it is changes in commentary.)

Thanks.



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Speedup of functions to en/decode UTF-8 text
  2019-11-23  9:37 Speedup of functions to en/decode UTF-8 text Eli Zaretskii
  2019-11-23 10:43 ` João Távora
@ 2019-11-23 15:27 ` Stefan Monnier
  2019-11-23 18:42 ` Dmitry Gutov
       [not found] ` <CACCVLQWT8msiij50wSvzbCBwvEeh9jnXGsGA5xxGnY5DEOvvYw@mail.gmail.com>
  3 siblings, 0 replies; 7+ messages in thread
From: Stefan Monnier @ 2019-11-23 15:27 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel, Ivan Yonchovski, João Távora

> handling.  Some preliminary benchmarking of the decoding function
> indicates speed improvements starting at modest 30-40%, and sometimes
> much higher -- tenfold or more.

Cool!


        Stefan




^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Speedup of functions to en/decode UTF-8 text
  2019-11-23  9:37 Speedup of functions to en/decode UTF-8 text Eli Zaretskii
  2019-11-23 10:43 ` João Távora
  2019-11-23 15:27 ` Stefan Monnier
@ 2019-11-23 18:42 ` Dmitry Gutov
  2019-11-23 18:49   ` Eli Zaretskii
       [not found] ` <CACCVLQWT8msiij50wSvzbCBwvEeh9jnXGsGA5xxGnY5DEOvvYw@mail.gmail.com>
  3 siblings, 1 reply; 7+ messages in thread
From: Dmitry Gutov @ 2019-11-23 18:42 UTC (permalink / raw)
  To: Eli Zaretskii, Ivan Yonchovski, João Távora; +Cc: emacs-devel

On 23.11.2019 11:37, Eli Zaretskii wrote:
> I've made some changes in the functions that encode and decode UTF-8
> text in an optimized fashion.  This is expected to speed up JSON
> handling.  Some preliminary benchmarking of the decoding function
> indicates speed improvements starting at modest 30-40%, and sometimes
> much higher -- tenfold or more.  I'm not sure how this will fare in
> the real-life handling of JSON objects

This is great. But were those 30-40% improvements in tests with strings 
or JSON decoding?

I tested two old examples, and the difference is <10% (like 0.78s down 
to 0.73s in the best case). Which is still welcome, of course.



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Speedup of functions to en/decode UTF-8 text
  2019-11-23 18:42 ` Dmitry Gutov
@ 2019-11-23 18:49   ` Eli Zaretskii
  0 siblings, 0 replies; 7+ messages in thread
From: Eli Zaretskii @ 2019-11-23 18:49 UTC (permalink / raw)
  To: Dmitry Gutov; +Cc: emacs-devel, yyoncho, joaotavora

> Cc: emacs-devel@gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Sat, 23 Nov 2019 20:42:09 +0200
> 
> On 23.11.2019 11:37, Eli Zaretskii wrote:
> > I've made some changes in the functions that encode and decode UTF-8
> > text in an optimized fashion.  This is expected to speed up JSON
> > handling.  Some preliminary benchmarking of the decoding function
> > indicates speed improvements starting at modest 30-40%, and sometimes
> > much higher -- tenfold or more.  I'm not sure how this will fare in
> > the real-life handling of JSON objects
> 
> This is great. But were those 30-40% improvements in tests with strings 
> or JSON decoding?

With JSON decoding.  But I have a very small sample of that.

> I tested two old examples, and the difference is <10% (like 0.78s down 
> to 0.73s in the best case). Which is still welcome, of course.

As long as it's faster, I'm okay ;-)

Thanks for testing.



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: Speedup of functions to en/decode UTF-8 text
       [not found] ` <CACCVLQWT8msiij50wSvzbCBwvEeh9jnXGsGA5xxGnY5DEOvvYw@mail.gmail.com>
@ 2019-11-24 17:12   ` Eli Zaretskii
  0 siblings, 0 replies; 7+ messages in thread
From: Eli Zaretskii @ 2019-11-24 17:12 UTC (permalink / raw)
  To: yyoncho; +Cc: emacs-devel

> From: yyoncho <yyoncho@gmail.com>
> Date: Sun, 24 Nov 2019 18:44:28 +0200
> 
> Hi Eli,
> 
> Thank you for the heads up.
> 
> I run the lsp-mode benchmark test and I observed ~30% speedup of JSON parsing. 

OK, thanks for letting us know.



^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2019-11-24 17:12 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-23  9:37 Speedup of functions to en/decode UTF-8 text Eli Zaretskii
2019-11-23 10:43 ` João Távora
2019-11-23 10:48   ` Eli Zaretskii
2019-11-23 15:27 ` Stefan Monnier
2019-11-23 18:42 ` Dmitry Gutov
2019-11-23 18:49   ` Eli Zaretskii
     [not found] ` <CACCVLQWT8msiij50wSvzbCBwvEeh9jnXGsGA5xxGnY5DEOvvYw@mail.gmail.com>
2019-11-24 17:12   ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).