From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Turning c-ts-mode.el, go-ts-mode.el, csharp-ts-mode.el etc into :core packages? Date: Tue, 7 Mar 2023 17:06:28 +0200 Message-ID: <68a6b078-f91a-d392-f37f-53a86b76465b@yandex.ru> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29253"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 To: Yuan Fu , Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 07 16:07:22 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZYuO-0007Ns-W1 for ged-emacs-devel@m.gmane-mx.org; Tue, 07 Mar 2023 16:07:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZYtf-0006eq-BG; Tue, 07 Mar 2023 10:06:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZYtd-0006dL-H9 for emacs-devel@gnu.org; Tue, 07 Mar 2023 10:06:33 -0500 Original-Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZYtb-0006qg-HX for emacs-devel@gnu.org; Tue, 07 Mar 2023 10:06:33 -0500 Original-Received: by mail-wr1-x430.google.com with SMTP id bw19so12413450wrb.13 for ; Tue, 07 Mar 2023 07:06:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678201590; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=P4v3tJLbs5/qD8ZvmsKEcZdPyUOWFnBO1RQ7+vzr35E=; b=LPHkWIu0UOCYddiHT/JAmhTdNOXvq3F7bIaTEKCbDkvsHlh2/+tW/BcZr7V23Mxchx CN37L213dDFOnVP41cI2o9uZ2LLW0GvnLjriHUGKCzDstEdgyjkf2rBDueR7kq/jecfO MqiDaxAoLyoWZZsQAqETcIqZHEumOdS3wKcnV5d1h3UA8woTGzhBhe4+4pOsz7owmUYC cIY1ZR7cS2hrCHiuH5/WeuE1rRuc5J+SsbYIONi0vZihy9QUlwBQXY82Us97uemGnXHr vO/SiPNW0kKYbf22ZDeCflD99li/ETOoS5oF2cSKobCvuA1wjxVT8IpzqDH1GrRA90dY mTQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678201590; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=P4v3tJLbs5/qD8ZvmsKEcZdPyUOWFnBO1RQ7+vzr35E=; b=E2Bkze56QQccMIZWqq9tgNTbB9Uz3gBqs6zHSjWJIoUn50l4CJ+svCaDz2+mpCY01J Z+W4Avnv1RNmkeTO9Vcj8xYcw5NBDMMan2RCaF7FpjDacmO9OLwI+nRzqi/w7OF/dBtP PedwZhmIdTMNULQ1qVfx+fFOQzTKZ87d9zIK01CWTdL7Eqn0oipdgSvnPw6WfErLI4AL WIaItA+mvJjUIsEq5XFeo4cJpSzALEc2J1dSJlJNod3X+h0ruju93gDloef8r+Gw3azS 4El6kGq+LCZMZ4XNa5fW4mFVvXc8cuD/s0Hr8Kdj3hZCtGgEgLxoT6pBvajptDOJCsV1 3RJQ== X-Gm-Message-State: AO0yUKWN4ypZM/72zLR6Rhmruqy2POmHrYtp+BacZ4p9z26odDv+CoTO No6oD57iCflwtYPhsmlCNGU= X-Google-Smtp-Source: AK7set+rpgymRA/dqmYpLtgWR81WRQDNqCAMetIHLEmoybOzUhhaq1NurNPLE89m9pOJJulqomargw== X-Received: by 2002:adf:db0f:0:b0:2c7:454:cee8 with SMTP id s15-20020adfdb0f000000b002c70454cee8mr9468282wri.1.1678201589945; Tue, 07 Mar 2023 07:06:29 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id q10-20020a5d658a000000b002c70851fdd8sm12814148wru.75.2023.03.07.07.06.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Mar 2023 07:06:29 -0800 (PST) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=raaahh@gmail.com; helo=mail-wr1-x430.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304087 Archived-At: On 06/03/2023 00:41, Yuan Fu wrote: > What are the implications of turning something into a :core package? I can’t find much description of it. If my understanding of it is correct, I think it would be beneficial to make new tree-sitter modes into :core packages. Right now they are pretty bare-bones, and haven’t been “battle-tested”. Making them core packages would allow us gradually improve them and fix errors that come up. Those files I mentioned in the subject are new files, if that matters. But I don’t know if there are any downsides of turning something into a :core package. Most of the associated overhead is having to keep in mind the version of Emacs that each packages advertises compatibility with. Which makes using new features (or fixes) from future Emacs versions harder (requiring versions checks, etc). We could also make treesit.el into a :core package at some point, if any of the packages will need some new changes. Although this one will likely depend on changes in treesit.c even more often. But for this package, at least, it might be worth it to set the "Version:" header in advance.