From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: Tree-sitter api Date: Sun, 8 Aug 2021 17:56:33 -0500 Message-ID: <68AF72EA-8662-4508-B46C-0ACA94A20E86@gmail.com> References: <83r1f7hydn.fsf@gnu.org> <95F37923-5BF9-4D81-B361-267CF119FBCA@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29672"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Stephen Leake , =?utf-8?Q?Cl=C3=A9ment_Pit-Claudel?= , emacs-devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 09 00:57:13 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mCrjE-0007O0-KS for ged-emacs-devel@m.gmane-mx.org; Mon, 09 Aug 2021 00:57:12 +0200 Original-Received: from localhost ([::1]:51060 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mCrjC-0002DC-TU for ged-emacs-devel@m.gmane-mx.org; Sun, 08 Aug 2021 18:57:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52862) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mCrih-0001Y1-3T for emacs-devel@gnu.org; Sun, 08 Aug 2021 18:56:39 -0400 Original-Received: from mail-ot1-x332.google.com ([2607:f8b0:4864:20::332]:42620) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mCrif-0005H1-Pg; Sun, 08 Aug 2021 18:56:38 -0400 Original-Received: by mail-ot1-x332.google.com with SMTP id d10-20020a9d4f0a0000b02904f51c5004e3so11553108otl.9; Sun, 08 Aug 2021 15:56:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=fJV10iMPjLBko51iQihP/Pmz8ue2xjWMQpx05tGmKlw=; b=NosYhWs5zgH6ikhjTAmk7DBweSDe31ItzC2TcOAhm0UHANcdBOtI0INqkQS//uUbAC G+vzu6gqmX2E6IL52wUTwTqbo4JsKEW4h7I18TkQ0e81pDgLr3HqjAMUNm+YXSJ++Xmh UE7kSeB4YSVHuhjOnjYXGpCh+fpdkWKOek/GLYRk9K8A8uJbbnokLaYXSvgzSxsGR5Xx nehtgZbUvzZRSF6wDsLouPswgO764pelg1autn+nUplxxrnemdgnfgDS8RON9iQq9Rou Y+LypdsyPDBwzA6KtxG+WhNcYPwiuIllV+ZNgj48WmksWxzDuT6dt9TJ7BrK2nM2azB/ RVhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=fJV10iMPjLBko51iQihP/Pmz8ue2xjWMQpx05tGmKlw=; b=Ns8eMzhBlArPi6m+E4jIrED5LQjafPbqHwwPG0rH8EQ5BG+m1g4K/jI1jywOnmH/Ih GQf2jEcnowXOFch945+tmav64uB1RCxuvjlwTYbFObbEHcPlc2F7toTy/NAHAPhn5l4p 1l+4UvwWCUby7t4QULAhKzYCo1SFw8mrFESkeGYqwz3SDUJUn7OHNkwhA8+TBS+bWJSs A3VYqwocAQswIoPgm870J664eJ29TNjoKypHCwTQaIQ3YA4SdvN0FMzdHbILhVu/eFeZ naKxSIaESWGe2bh5Exm2rM4fX+3ijO7Cj7h/eES3YsOQwGWYnGtGMMErgEpGL5AyK3nf PGWg== X-Gm-Message-State: AOAM530AF1ZqBWFFbfnN2L1UEooOs5sPnq2ER74E5q0lRv2zwclhV4Af nk6czXvUAZehDxYmxwZ0o3Y= X-Google-Smtp-Source: ABdhPJx6ArRLncfUIoWTw07viEzwGsCsjMHYtKL8zn0l9rr7CTui0bXeB+aHM3/m16CtPkSXM01DvA== X-Received: by 2002:a9d:6003:: with SMTP id h3mr12081924otj.42.1628463394866; Sun, 08 Aug 2021 15:56:34 -0700 (PDT) Original-Received: from [192.168.140.114] ([209.36.134.66]) by smtp.gmail.com with ESMTPSA id w16sm440770oih.19.2021.08.08.15.56.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Aug 2021 15:56:34 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3654.60.0.2.21) Received-SPF: pass client-ip=2607:f8b0:4864:20::332; envelope-from=casouri@gmail.com; helo=mail-ot1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:272212 Archived-At: > On Aug 7, 2021, at 10:47 AM, Stefan Monnier = wrote: >=20 >> We should have a user option to control tree-sitter on major mode >> level. Maybe an alist where each car is a major node symbol and each = cdr is >> a Boolean value toggling tree-sitter for that node. >=20 > The more traditional approach is to use a buffer-local var set by the > major mode or set via (add-hook '-hook ...). The major-mode would setup things like font-lock-defaults and = tree-sitter-defaults before major-mode-hook runs, so I think = enabling/disabling tree-sitter in the hook is too late, no? >=20 >> As for indentation, we could provide some infrastructure like we do = for >> font-locking, or we can just let major modes implement their indent = function >> with tree-sitter api. >=20 > We should definitely provide the infrastructure (even if it's fairly > simple) so that major modes only have to provide some rules. I don=E2=80=99t really know much about indenting but I=E2=80=99ll try my = best. Suggestions are definitely welcome. Yuan=