From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Yikai Zhao" Newsgroups: gmane.emacs.devel Subject: [PATCH] Fix memory-report--object-size for hashtable and vectors Date: Sat, 14 Aug 2021 18:18:13 +0800 Message-ID: <67bebb91-aa22-4901-bf8a-d461c1a73454@www.fastmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=5a646be35eaa479c83bb8c165ff2d00d Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1953"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Cyrus-JMAP/3.5.0-alpha0-1082-gccb13bca62-fm-ubox-20210811.001-gccb13bca To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Aug 14 13:24:12 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mErlr-0000CO-CG for ged-emacs-devel@m.gmane-mx.org; Sat, 14 Aug 2021 13:24:12 +0200 Original-Received: from localhost ([::1]:60976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mErlq-0007m7-5o for ged-emacs-devel@m.gmane-mx.org; Sat, 14 Aug 2021 07:24:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40920) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mEqkR-0005nI-AZ for emacs-devel@gnu.org; Sat, 14 Aug 2021 06:18:39 -0400 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:37221) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mEqkP-0006kb-H3 for emacs-devel@gnu.org; Sat, 14 Aug 2021 06:18:39 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CDBDD5C00AC for ; Sat, 14 Aug 2021 06:18:34 -0400 (EDT) Original-Received: from imap7 ([10.202.2.57]) by compute1.internal (MEProxy); Sat, 14 Aug 2021 06:18:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blahgeek.com; h= mime-version:message-id:date:from:to:subject:content-type; s= fm3; bh=hDFcRlFCdev4DM4LKp3d05uK7Omjs5g2dVZE1aaCWRo=; b=JT0TLwQE Gze560ZCCLU92yYMKttH9Mwww+2sBIsO/tliVlkWwv0yJsgO/ETRhYRpuf6NnUic SZZNFkWpL1eJ958rjA8knhiyPmCVHEyUEw8CsMguDVo8DpQ7MOSaKeHOKs5bR0d3 7ftu/d5QbSBV55rv6tpwY/jO95sujDDvwPYQALdb68YdGB6c92jU1HrVHWBIRSbJ tr6J08t7MlxwzLaOn4gsqvG2ILEY2t9SzzauD4UwpwwSnVzOe2bVP+Rf7o8Z89ZZ lQSbj1Ih2zx+4yP1Wn6luUjz2Mba+Y1uw+ll2ltS4FQ/ZyEpxOasCfHoEa+dvaqs GxplD7q9fL0hDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=hDFcRlFCdev4DM4LKp3d05uK7Omjs 5g2dVZE1aaCWRo=; b=wDc7Omt9oMQX1EIV3sI6kLwEgEry5NDPaHovlElTlx+2S GHVR+rCHUZATbJflKOI510USBlrspMZ+vB9pn7Ql51CpfvbFw+MUuDgGjGW/DKFU Dw+Nyd2Gh6GlxmUvZRA9mlaGdmSoxpnxpKWfa5ESLkG0GKjOX+kugjXMoZQqmBen GRtqMEmNbJt/lqv+SPBiJ0KZ2eHP2SiT8ywXNxwrqGLJucd/vZk8MXDDNh9ux2Yf jJk3G8M3dev5lYTAMrzAEmpfGlyXIbFzKplKYUTEcZh/GNLJtUelVuCou+Sr+E2v DkbI4HnlxxPHdrRuBZJTM4jl/4XZaZVSjvQ1KSL8Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrkeejgddvjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkfffhvffutgesmhdtreerre ertdenucfhrhhomhepfdgjihhkrghiucgkhhgrohdfuceoihessghlrghhghgvvghkrdgt ohhmqeenucggtffrrghtthgvrhhnpefghefghfeiteehlefghfefteduveelieffudejue efueevfedutdegteejvddtvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep mhgrihhlfhhrohhmpehisegslhgrhhhgvggvkhdrtghomh X-ME-Proxy: Original-Received: by mailuser.nyi.internal (Postfix, from userid 501) id 7550F360103; Sat, 14 Aug 2021 06:18:34 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Received-SPF: pass client-ip=66.111.4.25; envelope-from=i@blahgeek.com; helo=out1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sat, 14 Aug 2021 07:23:25 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:272381 Archived-At: --5a646be35eaa479c83bb8c165ff2d00d Content-Type: text/plain Hi, I'd like to send a simple patch to fix the `memory-report--object-size' function in memory-report.el. Currently it did not give correct object size for hashtable and vector objects, this patch fixes that. I noticed this bug because when I did `memory-report', the result items in "Largest Variables" list were unreasonably small and it did not match the "Overall Object Memory Usage". With this patch, this should be solved. To verify this, execute the following code: (memory-report--object-size (make-hash-table :test #'eq) ["long string that should be at least 40 bytes"]) The expected output should be a number greater than 40. This is my first attempt to submit a patch to emacs, please let me know if there's anything missing. Thanks! Yikai --5a646be35eaa479c83bb8c165ff2d00d Content-Disposition: attachment;filename="0001-Fix-memory-report-object-size-for-hashtable-and-vect.patch" Content-Type: text/x-patch; name="0001-Fix-memory-report-object-size-for-hashtable-and-vect.patch" Content-Transfer-Encoding: BASE64 RnJvbSBjYmVjODAwOWJlOGM3YzQ5NjA3ZWMzZmUwNmZiYmEyMTc4ZWQyZjA2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBCbGFoR2VlayA8aUBibGFoZ2Vlay5jb20+CkRhdGU6 IFNhdCwgMTQgQXVnIDIwMjEgMTg6MDE6MTcgKzA4MDAKU3ViamVjdDogW1BBVENIXSBGaXgg bWVtb3J5LXJlcG9ydC0tb2JqZWN0LXNpemUgZm9yIGhhc2h0YWJsZSBhbmQgdmVjdG9ycwoK UHJldmlvdXNseSB0aGUgZWxlbWVudHMgZ2V0IGluc2VydGVkIHRvIHRoZSAnY291bnRlZCcg dGFibGUgKmJlZm9yZSoKdGhleSBnZXQgYWNjb3VudGVkLiBUaGF0IG9wZXJhdGlvbiBpcyB1 bm5lY2Vzc2FyeSBiZWNhdXNlIGl0IHdpbGwgYmUKZG9uZSBhdCB0aGUgYmVnaW5uaW5nIG9m IGBtZW1vcnktcmVwb3J0LS1vYmplY3Qtc2l6ZWAKLS0tCiBsaXNwL2VtYWNzLWxpc3AvbWVt b3J5LXJlcG9ydC5lbCB8IDQgKy0tLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCsp LCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9tZW1vcnkt cmVwb3J0LmVsIGIvbGlzcC9lbWFjcy1saXNwL21lbW9yeS1yZXBvcnQuZWwKaW5kZXggMTEy NWRkZTQwNS4uMTgxNWRlZWM0MCAxMDA2NDQKLS0tIGEvbGlzcC9lbWFjcy1saXNwL21lbW9y eS1yZXBvcnQuZWwKKysrIGIvbGlzcC9lbWFjcy1saXNwL21lbW9yeS1yZXBvcnQuZWwKQEAg LTIzMCw3ICsyMzAsNyBAQCBtZW1vcnktcmVwb3J0LS1vYmplY3Qtc2l6ZS0xCiAgIChsZXQg KCh0b3RhbCAoKyAobWVtb3J5LXJlcG9ydC0tc2l6ZSAndmVjdG9yKQogICAgICAgICAgICAg ICAgICAgKCogKG1lbW9yeS1yZXBvcnQtLXNpemUgJ29iamVjdCkgKGxlbmd0aCB2YWx1ZSkp KSkpCiAgICAgKGNsLWxvb3AgZm9yIGVsZW0gYWNyb3NzIHZhbHVlCi0gICAgICAgICAgICAg ZG8gKHNldGYgKGdldGhhc2ggZWxlbSBjb3VudGVkKSB0KQorICAgICAgICAgICAgIGRvCiAg ICAgICAgICAgICAgKGNsLWluY2YgdG90YWwgKG1lbW9yeS1yZXBvcnQtLW9iamVjdC1zaXpl IGNvdW50ZWQgZWxlbSkpKQogICAgIHRvdGFsKSkKIApAQCAtMjM5LDggKzIzOSw2IEBAIG1l bW9yeS1yZXBvcnQtLW9iamVjdC1zaXplLTEKICAgICAgICAgICAgICAgICAgICgqIChtZW1v cnktcmVwb3J0LS1zaXplICdvYmplY3QpIChoYXNoLXRhYmxlLXNpemUgdmFsdWUpKSkpKQog ICAgIChtYXBoYXNoCiAgICAgIChsYW1iZGEgKGtleSBlbGVtKQotICAgICAgIChzZXRmIChn ZXRoYXNoIGtleSBjb3VudGVkKSB0KQotICAgICAgIChzZXRmIChnZXRoYXNoIGVsZW0gY291 bnRlZCkgdCkKICAgICAgICAoY2wtaW5jZiB0b3RhbCAobWVtb3J5LXJlcG9ydC0tb2JqZWN0 LXNpemUgY291bnRlZCBrZXkpKQogICAgICAgIChjbC1pbmNmIHRvdGFsIChtZW1vcnktcmVw b3J0LS1vYmplY3Qtc2l6ZSBjb3VudGVkIGVsZW0pKSkKICAgICAgdmFsdWUpCi0tIAoyLjMy LjAKCg== --5a646be35eaa479c83bb8c165ff2d00d--