From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Win Treese Newsgroups: gmane.emacs.devel Subject: Wondering about FACE_CACHE_BUCKETS_SIZE Date: Tue, 9 Feb 2021 21:53:34 -0500 Message-ID: <673E9F11-29F6-4F5B-B754-34FD9776DDB6@acm.org> Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8396"; mail-complaints-to="usenet@ciao.gmane.io" To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 10 03:54:28 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9fe8-00024d-0L for ged-emacs-devel@m.gmane-mx.org; Wed, 10 Feb 2021 03:54:28 +0100 Original-Received: from localhost ([::1]:52390 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9fe7-0007Ql-3A for ged-emacs-devel@m.gmane-mx.org; Tue, 09 Feb 2021 21:54:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43958) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9fdM-0006z4-7K for emacs-devel@gnu.org; Tue, 09 Feb 2021 21:53:41 -0500 Original-Received: from forward4-smtp.messagingengine.com ([66.111.4.238]:36457) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9fdK-0005ou-GX for emacs-devel@gnu.org; Tue, 09 Feb 2021 21:53:40 -0500 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailforward.nyi.internal (Postfix) with ESMTP id 3A94E1940C72 for ; Tue, 9 Feb 2021 21:53:36 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 09 Feb 2021 21:53:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=eUIaT0 zppX3UcIQk/42AYinUGuVuF4UqxcR6s38ENjc=; b=sA7V2bFf8sPyBDHz5oxrgg pLJSUhXoAX+SgnGxVPSWTrzmOz8cE/+MyZqhYj84qGJDmIVDLjOzJxQ3P8rM8t7U xr6lrhNxPxV+CwSSC0jB+mMD17WH+H3IqB6SH10XS2yUPg49QacA/d0S/ugiUS2d Be252HB4bs0ZY+HgWbE+m6bNnWxB/7IPVs/E/hwcxKxH0gU+67Je6SPfWSfmH8Hv 8Gme7gaysVVbWDV+ix/mh/etTKmQCuz8nBzSa6/mljV3i9DmnvDTgfY6Tpzefnnz 86/eKCo1Jb16GbE7lNzfbBivkNJw0+UIRgMt9N1ay6W1RS+9KE+Bf4XDIsgqxYgw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrheeigdehfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephfgtgfgguffkfffvofesthhqmhdthh dtjeenucfhrhhomhephghinhcuvfhrvggvshgvuceothhrvggvshgvsegrtghmrdhorhhg qeenucggtffrrghtthgvrhhnpeejgfevhfetgffgteehieegteeikeekheegfefhheehhe ffleeuhfdtfffghfdvheenucfkphepudehuddrvddtfedrheekrddutdehnecuvehluhhs thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhrvggvshgvsegrtg hmrdhorhhg X-ME-Proxy: Original-Received: from [127.0.0.1] (pool-151-203-58-105.bstnma.fios.verizon.net [151.203.58.105]) by mail.messagingengine.com (Postfix) with ESMTPA id 8A764240062 for ; Tue, 9 Feb 2021 21:53:35 -0500 (EST) X-Mao-Original-Outgoing-Id: 634618414.90131-62bd1232e6ef5d5c5daf57e7857ca610 X-Mailer: Apple Mail (2.3608.120.23.2.4) Received-SPF: softfail client-ip=66.111.4.238; envelope-from=treese@acm.org; helo=forward4-smtp.messagingengine.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:264257 Archived-At: I happened to be looking at some code in src/xfaces.c on the trunk, and = I noticed this at lines 289-292: /* Size of hash table of realized faces in face caches (should be a prime number). */ #define FACE_CACHE_BUCKETS_SIZE 1001 1001 isn=E2=80=99t prime (it=E2=80=99s 7*11*13). A quick look at the = hash table code suggest that the main effect of it is to slow things down a little bit because some hash buckets would get used more often than they would be with a prime.=20 =46rom the git log, it=E2=80=99s been this way since the code was first = committed in 1999. There=E2=80=99s probably no real problem here, except that the comment = and code don=E2=80=99t match. On the other hand, 997 and 1009 are nice = nearby primes if it really matters. - Win