Re: [Emacs-diffs] emacs-26 e5a2933: lisp/vc/: documentation fixes

Re: [Emacs-diffs] emacs-26 e5a2933: lisp/vc/: documentation fixes

[Dmitry Gutov]

Hi all,

On 2/17/18 5:40 PM, Charles A. Roelli wrote:

>   (defun change-log-get-method-definition ()
> -"For Objective C, return the method name if we are in a method."
> +  "For Objective C, return the method name if we are in a method."
>     (let ((change-log-get-method-definition-md "["))
>       (save-excursion
>         (if (re-search-backward "^@implementation\\s-*\\([A-Za-z_]*\\)" nil t)

Isn't it weird how we have an Objective-C specific function inside 
add-log.el?

It isn't used anywhere in Emacs these days, AFAICT.

Re: [Emacs-diffs] emacs-26 e5a2933: lisp/vc/: documentation fixes

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > Isn't it weird how we have an Objective-C specific function inside 
  > add-log.el?

It makes sense for add-log.el to support all sorts of obscure languages.
If change-log-get-method-definition is not used anywhere, maybe that failure
to call it is a bug.

-- 
Dr Richard Stallman
President, Free Software Foundation (https://gnu.org, https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)
Skype: No way! See https://stallman.org/skype.html.

Re: [Emacs-diffs] emacs-26 e5a2933: lisp/vc/: documentation fixes

[Dmitry Gutov]

On 2/21/18 12:06 PM, Richard Stallman wrote:
> [[[ To any NSA and FBI agents reading my email: please consider    ]]]
> [[[ whether defending the US Constitution against all enemies,     ]]]
> [[[ foreign or domestic, requires you to follow Snowden's example. ]]]
> 
>    > Isn't it weird how we have an Objective-C specific function inside
>    > add-log.el?
> 
> It makes sense for add-log.el to support all sorts of obscure languages.

It would be silly, code organization-wise. Major modes should contain 
that support code. And indeed, they do that via 
add-log-current-defun-function or add-log-current-defun-header-regexp. 
objc-mode sets both variables.

> If change-log-get-method-definition is not used anywhere, maybe that failure
> to call it is a bug.

It seems to me people simply forgot to remove it after the code was 
factored out.

Around Emacs 20.1, the definition of add-log-current-defun was much 
longer and called this function (named differently back then), among 
many other things.

Re: [Emacs-diffs] emacs-26 e5a2933: lisp/vc/: documentation fixes

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > > It makes sense for add-log.el to support all sorts of obscure languages.

  > It would be silly, code organization-wise. Major modes should contain 
  > that support code. And indeed, they do that via 
  > add-log-current-defun-function or add-log-current-defun-header-regexp. 
  > objc-mode sets both variables.

Your statement and mine do not conflict.

-- 
Dr Richard Stallman
President, Free Software Foundation (https://gnu.org, https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)
Skype: No way! See https://stallman.org/skype.html.