From: Dmitry Gutov <dgutov@yandex.ru>
To: rms@gnu.org
Cc: charles@aurox.ch, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-26 e5a2933: lisp/vc/: documentation fixes
Date: Wed, 21 Feb 2018 18:33:07 +0200 [thread overview]
Message-ID: <66e1e49d-fa0d-ff06-e9d4-3843271969a9@yandex.ru> (raw)
In-Reply-To: <E1eoRID-0001Cg-IQ@fencepost.gnu.org>
On 2/21/18 12:06 PM, Richard Stallman wrote:
> [[[ To any NSA and FBI agents reading my email: please consider ]]]
> [[[ whether defending the US Constitution against all enemies, ]]]
> [[[ foreign or domestic, requires you to follow Snowden's example. ]]]
>
> > Isn't it weird how we have an Objective-C specific function inside
> > add-log.el?
>
> It makes sense for add-log.el to support all sorts of obscure languages.
It would be silly, code organization-wise. Major modes should contain
that support code. And indeed, they do that via
add-log-current-defun-function or add-log-current-defun-header-regexp.
objc-mode sets both variables.
> If change-log-get-method-definition is not used anywhere, maybe that failure
> to call it is a bug.
It seems to me people simply forgot to remove it after the code was
factored out.
Around Emacs 20.1, the definition of add-log-current-defun was much
longer and called this function (named differently back then), among
many other things.
next prev parent reply other threads:[~2018-02-21 16:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180217154022.29183.21950@vcs0.savannah.gnu.org>
[not found] ` <20180217154025.25F47206A2@vcs0.savannah.gnu.org>
2018-02-20 0:06 ` [Emacs-diffs] emacs-26 e5a2933: lisp/vc/: documentation fixes Dmitry Gutov
2018-02-21 10:06 ` Richard Stallman
2018-02-21 16:33 ` Dmitry Gutov [this message]
2018-02-22 8:01 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66e1e49d-fa0d-ff06-e9d4-3843271969a9@yandex.ru \
--to=dgutov@yandex.ru \
--cc=charles@aurox.ch \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).