From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Per Abrahamsen" Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: multiple queries to delete excess backup version w/ custom Date: Sun, 6 Jan 2008 14:26:45 +0100 Message-ID: <66a8b7a0801060526v422437f7wac91df8dda849476@mail.gmail.com> References: <477EB51F.3050003@gmx.at> <477EBD26.5060709@gmx.at> <477F5A39.1070904@gmx.at> <478004AF.80907@gmx.at> <66a8b7a0801051546m29e9cc07p84b991a16e59ace@mail.gmail.com> <4780A8CA.2000200@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1199626345 11443 80.91.229.12 (6 Jan 2008 13:32:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 6 Jan 2008 13:32:25 +0000 (UTC) Cc: Tom Tromey , emacs-pretest-bug@gnu.org To: "martin rudalics" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 06 14:32:45 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JBVcF-0004q5-AT for ged-emacs-devel@m.gmane.org; Sun, 06 Jan 2008 14:32:40 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JBVbr-00030T-JF for ged-emacs-devel@m.gmane.org; Sun, 06 Jan 2008 08:32:15 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JBVbl-0002zP-Hw for emacs-devel@gnu.org; Sun, 06 Jan 2008 08:32:09 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JBVbi-0002xs-JV for emacs-devel@gnu.org; Sun, 06 Jan 2008 08:32:07 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JBVbi-0002xn-A2 for emacs-devel@gnu.org; Sun, 06 Jan 2008 08:32:06 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JBVbi-0006kX-2c for emacs-devel@gnu.org; Sun, 06 Jan 2008 08:32:06 -0500 Original-Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JBVbh-0002vM-Ef for emacs-pretest-bug@gnu.org; Sun, 06 Jan 2008 08:32:05 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1JBVWZ-00067D-5y for emacs-pretest-bug@gnu.org; Sun, 06 Jan 2008 08:26:50 -0500 Original-Received: from wa-out-1112.google.com ([209.85.146.177]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JBVWY-000679-Sv for emacs-pretest-bug@gnu.org; Sun, 06 Jan 2008 08:26:47 -0500 Original-Received: by wa-out-1112.google.com with SMTP id k34so11813191wah.10 for ; Sun, 06 Jan 2008 05:26:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=zncqNXbS+gwwzQ3u3B84M4/sujSFhl7V1Tc1EqJ3v7c=; b=DxnUd8ux9RMxiMPY804zmdNghnpZ4Ma6PRNKgLR7+iAAJqoh/qWPvIa4scNucGMsxbzJ562WKPQwy2jJMgnooBN0vabwBdbJmUHHEH6vlvBfedQ/ZLdg3TYybAmoaxuocsJz/8r1YOL2b971D/Jng9isXkwJuWMzbpP23Fee4/A= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=v6tb99JWXNRvppVeIiHpF+kYbO7uy/WjTjyb/8+h4TX8q/5fpx/8CClRIZLwW2eh6iBGjOe0X8Fk9sRdO6Ds9clymTjj6Q03z0bHNu1T8ZMW89S/WMlrPY1liZD3ZUJnS47ko6CzI0D6gpmcDhvgg8AnE6JWcmEuG3wNAaIOqf8= Original-Received: by 10.114.120.1 with SMTP id s1mr20705394wac.125.1199626005543; Sun, 06 Jan 2008 05:26:45 -0800 (PST) Original-Received: by 10.114.79.10 with HTTP; Sun, 6 Jan 2008 05:26:45 -0800 (PST) In-Reply-To: <4780A8CA.2000200@gmx.at> Content-Disposition: inline X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:86325 gmane.emacs.pretest.bugs:20523 Archived-At: On Jan 6, 2008 11:09 AM, martin rudalics wrote: > Thank you for responding. The doc-string of `Custom-save' says > > "Set all edited settings, then save all settings that have been set." > > which inherently reduces to > > (widget-apply child :custom-set) > > followed by > > (custom-save-all) > > Can you recall why you needed > > (widget-apply child :custom-save) > > here, that is, something like: > > "Save all edited settings, then save all settings that have been set." custom-save-all will only save options that are explicitly marked for saving. :custom-set will set the option and mark it as set (customized), but will not mark it for saving. :custom-save should mark the option for saving, without actually saving. The bug is that :custom-save actually saves the option (and perhaps that it is poorly named, should be :custom-mark-for-saving). The problem is that the functions used for implementing the :custom-save method, such as custom-variable-save, are also sometimes used in contexts where you want to save the option immediately. These places the function should be split into one that marks only (and is used as the :custom-save (or :custom-mark-for--saving) method), and one that additionally calls custom-save-all. PS: describe-text-properties (or Edit -> Text Properties -> Describe Properties) is a great help when debugging various kind of forms, it knows about both the button and widget abstractions on top of text properties and overlays.