unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: David Reitter <david.reitter@gmail.com>
To: Emacs-Devel devel <emacs-devel@gnu.org>, mwolson@gnu.org
Subject: ERC: header-line-format nil
Date: Sun, 17 Aug 2008 19:46:13 +0100	[thread overview]
Message-ID: <66DD8F02-4C56-412B-B17F-5F145B75C0D2@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 858 bytes --]

When `erc-header-line-format' is set to nil, the header line should  
not be set in order to avoid interfering with minor modes that may use  
it (e.g., tabbar).  Is it OK to apply the patch below?




*** erc.el	28 Jul 2008 23:15:49 +0100	1.52
--- erc.el	17 Aug 2008 19:44:33 +0100	
***************
*** 6085,6092 ****
   	(let ((header (if erc-header-line-format
   			  (format-spec erc-header-line-format spec)
   			nil)))
! 	  (cond ((null header)
! 		 (setq header-line-format nil))
   		(erc-header-line-uses-help-echo-p
   		 (let ((help-echo (with-temp-buffer
   				    (insert header)
--- 6085,6091 ----
   	(let ((header (if erc-header-line-format
   			  (format-spec erc-header-line-format spec)
   			nil)))
! 	  (cond ((null header))
   		(erc-header-line-uses-help-echo-p
   		 (let ((help-echo (with-temp-buffer
   				    (insert header)


[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 2193 bytes --]

             reply	other threads:[~2008-08-17 18:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-17 18:46 David Reitter [this message]
2008-08-17 18:57 ` ERC: header-line-format nil Michael Olson
2008-08-17 19:18   ` David Reitter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66DD8F02-4C56-412B-B17F-5F145B75C0D2@gmail.com \
    --to=david.reitter@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=mwolson@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).