unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: JD Smith <jdtsmith@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Selective font-locking?
Date: Sun, 11 Apr 2021 16:54:28 -0400	[thread overview]
Message-ID: <65B869A0-CB0B-43C1-90EA-E2B259A74589@gmail.com> (raw)
In-Reply-To: <jwva6q4hjnk.fsf-monnier+emacs@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 2267 bytes --]

Definitely worth trying, thanks.  I came up with:

(defun python-shell-multiline--apply-font-lock (limit)
  (let ((end (cdr-safe comint-last-prompt)))
    (if (and end (> limit end))
	(let ((font-lock-keywords python-font-lock-keywords)
	      (font-lock-syntactic-face-function
	       #'python-font-lock-syntactic-face-function)
	      (start (max end (point))))
	  (font-lock-flush start limit)
	  (font-lock-ensure start limit)))))

(set (make-local-variable 'font-lock-keywords)
       '(python-shell-multiline--apply-font-lock)))

I can verify that font-lock-ensure is being called on an appropriate region (lots of times).  With either font-lock-flush or font-lock-ensure, no actual fontification occurs.  With both of these together (as above), this error is signaled:

Error during redisplay: (jit-lock-function 179) signaled (void-function python-font-lock-keywords-level-1)

Note that python-font-lock-keywords is a *list* beginning with this symbol:

Python-font-lock-keywords is a variable defined in ‘python.el’.
Its value is
(python-font-lock-keywords-level-1 python-font-lock-keywords-level-1 python-font-lock-keywords-level-2 python-font-lock-keywords-maximum-decoration)

Not sure why jit-lock-function would be evaluating it like an sexp.

> On Apr 11, 2021, at 12:31 PM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> 
>> But then, why bother round-tripping text out to a special-use buffer anyway,
>> vs. just letting font-lock operate in-situ in the shell buffer itself using
>> python-mode’s fairly simple font-lock-defaults. The only thing needed to
>> make this work is asking font-lock to ignore all the text with ‘field of
>> ‘output?  
> 
> Maybe you can try something like the following?
> 
>    (defvar python--font-lock-keywords ...)
>    (defvar python-font-lock-keywords
>      '(python--apply-font-lock))
>    (defun python--apply-font-lock (limit)
>      (while (< (point) limit)
>        (let ((next-boundary (find-next-boundary limit)))
>          (if (we-should-skip-this-block)
>              (goto-char next-boundary)
>            (let ((font-lock-keywords python--font-lock-keywords))
>              (font-lock-ensure (point) limit))))))
> 
> 
> -- Stefan
> 


[-- Attachment #2: Type: text/html, Size: 5199 bytes --]

  reply	other threads:[~2021-04-11 20:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-11 15:27 Selective font-locking? JD Smith
2021-04-11 16:31 ` Stefan Monnier
2021-04-11 20:54   ` JD Smith [this message]
2021-04-11 21:10     ` Stefan Monnier
2021-04-13  1:51       ` JD Smith
2021-04-13  2:07         ` Stefan Monnier
2021-04-13  3:33           ` JD Smith
2021-04-13  4:04             ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65B869A0-CB0B-43C1-90EA-E2B259A74589@gmail.com \
    --to=jdtsmith@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).