From: "Mattias Engdegård" <mattiase@acm.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Returning argument string (regexp-quote)
Date: Tue, 24 Sep 2019 19:44:21 +0200 [thread overview]
Message-ID: <658AF539-1AE7-459D-94C7-44970AA94EEF@acm.org> (raw)
In-Reply-To: <83sgoloedi.fsf@gnu.org>
24 sep. 2019 kl. 18.20 skrev Eli Zaretskii <eliz@gnu.org>:
>
>> More generally, do we need to preserve allocation for functions not specifically documented to return new strings? I can imagine there being code that depend on it by accident, but string mutation is rare.
>
> I think the benefits from such general changes are barely tangible,
> whereas the risk of breaking someone's (perhaps even ours) code are
> real. So I don't think we should do that, not in general.
Very well, I shan't go on a spree. What about the specific case of regexp-quote then?
It was responsible for a sizeable portion of local consing in some (non-public) code I was profiling.
Would the change need a mention in NEWS, and/or its doc string?
next prev parent reply other threads:[~2019-09-24 17:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 11:28 Returning argument string (regexp-quote) Mattias Engdegård
2019-09-24 11:49 ` Andreas Schwab
2019-09-24 16:20 ` Eli Zaretskii
2019-09-24 17:44 ` Mattias Engdegård [this message]
2019-09-24 18:24 ` Paul Eggert
2019-09-24 19:47 ` Eli Zaretskii
2019-09-25 13:41 ` Mattias Engdegård
2019-09-25 15:08 ` Eli Zaretskii
2019-09-25 19:55 ` Compilation failure on macOS 10.15 Catalina Zach Pearson
2019-09-25 20:29 ` mituharu
2019-09-25 21:55 ` Zach Pearson
2019-09-25 22:47 ` mituharu
2019-09-25 23:07 ` Zach Pearson
2019-09-25 23:39 ` mituharu
2019-09-27 23:22 ` chad
2019-10-02 3:59 ` Zach Pearson
2019-10-02 4:04 ` YAMAMOTO Mitsuharu
2019-10-02 4:34 ` Zach Pearson
2019-10-02 4:42 ` YAMAMOTO Mitsuharu
2019-10-02 4:43 ` Zach Pearson
2019-10-02 5:00 ` YAMAMOTO Mitsuharu
2019-10-02 5:07 ` Zach Pearson
2019-10-02 7:43 ` Zach Pearson
2019-10-02 15:15 ` Xu Xin
2019-09-26 8:34 ` Robert Pluim
2019-09-26 16:05 ` Zach Pearson
2019-09-26 21:00 ` mituharu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=658AF539-1AE7-459D-94C7-44970AA94EEF@acm.org \
--to=mattiase@acm.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).